-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Political party names #208
base: Development
Are you sure you want to change the base?
Conversation
-Added historical names to some political parties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big one, so I only looked at a couple things. On top of that I did not review dates, historicity, or policies. Instead I stuck to purely editorial remarks.
@@ -179,6 +179,7 @@ TUN_prussian_constitutionalism;Tunis;;;;;;;;;;;;; | |||
ALB_communist;Partia e Pun�s e Shqip�ris�;;;;;;;;;;;;; | |||
ALB_fascist;Partia Fashiste e Shqip�ris�;;;;;;;;;;;;; | |||
ALB_conservative;L�vizja Legalitetit;;;;;;;;;;;;; | |||
AUS_socialist_3;Sozialdemokratische Arbeiterpartei �sterreichs;;;;;;;;;;;;;x;;;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s my opinion (and not much more than that) that party names should dispense with the “… of Austria” or “Austrian…” qualifiers. My reasoning is as follows:
- party names are only ever displayed for internal matters, there is no confusion possible because the UI never displays things like “$GER_liberal$ have denounced the recent actions of the
$FRA_conservative_2$ ”—if you are looking at e.g. Germany, all it ever displays are German parties - the base UI sadly does not afford a lot of space for party names wherever they are displayed (for the most part: political panel, political screen, diplomatic screen), and I’m disappointed whenever I see a name that’s been cut off
- actual, formal party names of the time may not have included any national qualifiers, and even when they did these qualifiers were only used when disambiguating e.g. when discussing international events (this may have been the case for the Sozialdemokratische Arbeiterpartei, though I did not spend a ton of time on it)
To repeat myself, this is strictly my personal view on the matter. To my knowledge the mod does not take any stance, nor is it consistent. I’m also not inflexible on the matter:
- I normally don’t mind it when internationalist socialist or communist parties bear a mention of the country
- some party names are (in)famous or otherwise iconic enough that they are probably better off preserved in full
- in multiethnic/multinational states, some party names did adopt a qualifier to reflect their aims (e.g. the nationalist German parties outside Germany and Austria/Austria-Hungary)
- initialisms should probably be preserved (e.g. there is no benefit to dropping the countries in SFIO, NSDAP, etc.)
I’m only mentioning this once in this note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked again and the Austrian socialist party was initially named as the "Sozialdemokratische Arbeiterpartei", so I'll change that.
I'll also change the name of parties that cause problems with the UI.
BAN_fascist;The Nationalist Faction;Faction fasciste;Die faschistische Fraktion;;;;;;;;;;; | ||
BAN_socialist;Banat Sozialdemokratische Partei;;;;;;;;;;;;; | ||
BAN_communist;Communist Party;Faction communiste;Die kommunistische Fraktion;;;;;;;;;;; | ||
BAN_fascist;Nationalsozialistische Partei der rum�nischen Deutschen;;;;;;;;;;;;; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are „die rumänischen Deutsche” and variations attested? For the most part, I’m finding hits when looking for „die Rumäniendeutsche”. Because those hits are mostly from post-WWII documents, I have no idea if the term was contemporaneous to the time period covered by the game or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the name is too long, I'll change it to "Deutsche Volkspartei" which was another fascist party from the same period.
Hi man. I've been working in something like this for a while too. I decided that seeing the same generic names over and over again ruined part of my immersion into vic2 hpm so I decided to change all generic political party names into brand new ones, for my own personal enjoyment. I'm only renaming GENERIC political party names (such as 'The Socialist Faction'; 'Liberaldem. Partei' or 'Partido Conservador'). I haven't touched their dates, numbers or policies either.
I do some research into every party i'm renaming to see if there's an historic real-life party that can be put in its place, but most of the time this isn't the case. I also try to use as many historic elements as possible when doing this.
If it's an english speaking country, i get an english name for it. There aren't many english speaking countries that don't already have 'custom' political party names tho.
If it's a spanish speaking country, i get a spanish name for it
If it's not an english speaking country, but its language can be translated, at least loosely, to english, i try to respect this language.
If it's not an english speaking country, and its language cannot be translated to english with online tools, i just stick to english names
This still is a WIP and i'm about through 15% of it. I'll upload the changelog (open it in windows notepad) so you can see how it goes so far. Note that i had to make some other changes in the files when necessary, but it's all documented in the changelog. Also, this is my first time "modding" (i don't think this is actually modding, but whatever) a videogame or posting in github. I've never done it before, so please forgive me if i made a mistake formating this or editing the files. |
Added historical names to the political parties of Poland, Croatia, Dalmatia, Banat, Bukovina, Luxembourg, Austria, Bohemia, Czechoslovakia, Slovakia, Slovenia, Transylvania, Moldova, Crete, Armenia, New Zealand, Denmark, Galicia-Lodomeria, Ruthenia and Trieste.