Normalise nv change requirements #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all NV pick decisions are carefully weighted in order to produce a random AI outcome they all need consistent requirements.
arkhometha
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all NV pick decisions are carefully weighted in order to produce a
random AI outcome they all need consistent requirements.
First patch is the actual fix, very easy to review. Second patch is some editing of the comment with no semantic change, because I realised that 120 columns is too wide for e.g. Github. I did not test the changes.
I think I had originally overlooked that
switch_to_autocracyhas different requirements because it seemed intended, e.g. as a last resort button to placate reactionary rebels. However since that decision still gives a ton of reactionary militancy, I think it’s more likely it was a copy/paste mistake of some sorts.