-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2002: media.peerconnection.ice.* #580
Comments
OK, it's uBO's "Prevent WebRTC from leaking local IP addresses" (info icon links to here)
If you're wanting to actually plug leaks (and WebRTC is enabled), uBO needs those prefs in order to do its plugging leaks job - @gorhill is that correct? Are those the only two prefs it flips? TIA Us:
|
uBO uses the privacy extension API to set From the code, it seems only the config uBO uses |
FF ESR 52.0 has media.peerconnection.ice.default_address_only entry with false as default. |
My comment was how it works in Firefox 60+. Firefox 52 ESR is obsolete. |
I was replying to Pants:
|
you added that around October 3, 2016 but without mentioning any sources: this bug has some related information: https://bugzilla.mozilla.org/show_bug.cgi?id=1304600 test page (but I have no idea how you'd need to test that, probably need to be in a LAN to fully test if anything leaks): https://diafygi.github.io/webrtc-ips/ |
Thank goodness we came to github and have records of everything now. https://bugzilla.mozilla.org/show_bug.cgi?id=1297416 I think is the bugzilla |
https://bugzilla.mozilla.org/show_bug.cgi?id=1304600#c3
comment5
So that clears that up. It's still used, but not in the way it was prior to 51. I don't think it's worth documenting uBOs behavior because there is no downside (uBO takes care of what it needs on startup). @earthlng Do you think we could should change the FF versioning to just |
also use this issue for the suggestion to add a |
FYI, the https://www.privacytools.io/webrtc.html test in our wiki is 404, so I gave it a strikethru and added this one. This is also handy for 2001, but do we need to double up on it? We're only disabling WebRTC because of IP leaks, so I don't see the point in testing if WebRTC is disabled.
switch (value) {
case "default":
// All prefs are already set to be reset.
break;
case "default_public_and_private_interfaces":
prefs["media.peerconnection.ice.default_address_only"] = true;
break;
case "default_public_interface_only":
prefs["media.peerconnection.ice.default_address_only"] = true;
prefs["media.peerconnection.ice.no_host"] = true;
break;
case "disable_non_proxied_udp":
prefs["media.peerconnection.ice.proxy_only"] = true;
break;
} this is from the webextension Privacy API code. The 2nd non-default case sets both prefs (same as we currently do) and the last case is what uBO does. The mozilla dev said "proxy_only" is the more extreme but I don't know exactly what the difference is |
lets just bury this issue and leave it as is |
original post
Both of these are being reset to default false when FF restarts. And the first one, it's not deprecated, whats the 42-50 bit about?
The text was updated successfully, but these errors were encountered: