Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[patch]: support for patch verb #38

Merged
merged 14 commits into from
Aug 6, 2021

Conversation

jakeyheath
Copy link
Contributor

@jakeyheath jakeyheath commented Aug 2, 2021

This PR adds support for the "patch" verb. This would allow you to be able to call:

response = SsrfFilter.patch(params[:url]) # throws an exception for unsafe fetches

This PR resolves #38 . I needed to also update the maximum version of "psych" because 4.0 introduced a breaking change for YAML files with dates in them: ruby/psych#489

@coveralls
Copy link

coveralls commented Aug 2, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 0e8cbfe on jacobrheath:heathj/patchverb into ebb24a1 on arkadiyt:master.

@arkadiyt
Copy link
Owner

arkadiyt commented Aug 5, 2021

I tried pushing a commit to this branch but am having some issues with my github setup. Could you try adding a line here to pin rexml to 3.2.4? It might resolve the ruby 2.0 failure

@jakeyheath
Copy link
Contributor Author

Sure, let me try

@jakeyheath
Copy link
Contributor Author

@arkadiyt nice job! That seemed to have done it. Let me know if you have any other comments.

Copy link
Owner

@arkadiyt arkadiyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution

If you need this for a project let me know and I can push a new version to rubygems

@arkadiyt arkadiyt merged commit 437ba68 into arkadiyt:master Aug 6, 2021
@jakeyheath
Copy link
Contributor Author

O great, no rush. We are using it in a project, but its not super time-sensitive. Thanks for merging!

@jakeyheath jakeyheath deleted the heathj/patchverb branch August 6, 2021 15:33
@jakeyheath jakeyheath mentioned this pull request Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants