chore: add illegal expression test case.

arjenzhou · Jul 23, 2023 · 9cc87be · 9cc87be
1 parent 6d7af7e
commit 9cc87be
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 11 deletions.
diff --git a/scheduler/src/main/java/com/arjenzhou/kit/scheduler/job/internal/JobRunner.java b/scheduler/src/main/java/com/arjenzhou/kit/scheduler/job/internal/JobRunner.java
@@ -41,7 +41,8 @@ public void execute(JobExecutionContext context) {
                 }
                 scheduledJob.start();
                 LOG.info("Job " + scheduledJob.getClass().getTypeName() + " triggered by instanceId: " + context.getFireInstanceId() + " has completed");
-            } catch (ParseException ignored) {
+            } catch (ParseException e) {
+                LOG.error("Job " + scheduledJob.getClass().getTypeName() + " parse expression failed", e);
             }
         });
     }

diff --git a/scheduler/src/test/java/module-info.java b/scheduler/src/test/java/module-info.java
@@ -1,6 +1,7 @@
 import com.arjenzhou.kit.scheduler.job.ScheduledJob;
 import test.com.arjenzhou.kit.scheduler.CalculationJob;
 import test.com.arjenzhou.kit.scheduler.LogTimeJob;
+import test.com.arjenzhou.kit.scheduler.ParseFailedJob;
 
 /**
  * @author [email protected]
@@ -13,5 +14,5 @@
     requires org.slf4j;
     requires org.junit.jupiter.api;
 
-    provides ScheduledJob with LogTimeJob, CalculationJob;
+    provides ScheduledJob with LogTimeJob, CalculationJob, ParseFailedJob;
 }
diff --git a/scheduler/src/test/java/test/com/arjenzhou/kit/scheduler/ParseFailedJob.java b/scheduler/src/test/java/test/com/arjenzhou/kit/scheduler/ParseFailedJob.java
@@ -0,0 +1,16 @@
+package test.com.arjenzhou.kit.scheduler;
+
+import com.arjenzhou.kit.scheduler.job.MemorySchedulerJob;
+import com.arjenzhou.kit.scheduler.job.Scheduled;
+
+/**
+ * @author [email protected]
+ * @since 2023/7/24
+ */
+@Scheduled(cronExpression = "1113 * * * * ?")
+public class ParseFailedJob extends MemorySchedulerJob {
+    @Override
+    public void execute() {
+        // do nothing
+    }
+}
diff --git a/scheduler/src/test/resources/META-INF/services/com.arjenzhou.kit.scheduler.job.ScheduledJob b/scheduler/src/test/resources/META-INF/services/com.arjenzhou.kit.scheduler.job.ScheduledJob
@@ -1,2 +1,3 @@
 test.com.arjenzhou.kit.scheduler.LogTimeJob
-test.com.arjenzhou.kit.scheduler.CalculationJob
+test.com.arjenzhou.kit.scheduler.CalculationJob
+test.com.arjenzhou.kit.scheduler.ParseFailedJob
diff --git a/statemachine/src/test/java/test/com/arjenzhou/kit/fsm/Output.java b/statemachine/src/test/java/test/com/arjenzhou/kit/fsm/Output.java