RFC: Add Support for SMTP Server #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- BEGIN META VARIABLES -------- Project : Task : Done : --------- END META VARIABLES --------
--------- BEGIN META VARIABLES -------- Project : Task : Done : --------- END META VARIABLES --------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't actually merge this. The tests haven't been updated and I don't like the way the smtp code has been hooked in.
This code allows the use of an SMTP server instead of SES to forward the email. AWS and Google are not playing nice currently and Google is bouncing a lot of email coming through AWS. Since most of our mail forwarding goes to Google, this is a problem for us. I've modified the code to use authenticated SMTP and log into gmail, so we can reliably send mail to gmail.
This totally violates the purpose of an SES forwarder, but is still useful. So I wanted to gauge interest to see if I should clean up the changes and submit them for as a real pull request.