Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: pre-commit autoupdate #4843

Merged
merged 6 commits into from
Jan 3, 2025
Merged

CI: pre-commit autoupdate #4843

merged 6 commits into from
Jan 3, 2025

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Dec 23, 2024

@pre-commit-ci pre-commit-ci bot requested review from a team as code owners December 23, 2024 16:54
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4843
# Activate the virtual environment
source test-avd-pr-4843/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/aristanetworks/avd.git@pre-commit-ci-update-config#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/aristanetworks/avd.git#/ansible_collections/arista/avd/,pre-commit-ci-update-config --force
# Optional: Install AVD examples
cd test-avd-pr-4843
ansible-playbook arista.avd.install_examples

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc requested a review from a team December 23, 2024 17:25
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Dec 23, 2024
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.8.3 → v0.8.4](astral-sh/ruff-pre-commit@v0.8.3...v0.8.4)
- [github.com/pycqa/pylint: v3.3.2 → v3.3.3](pylint-dev/pylint@v3.3.2...v3.3.3)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 14bf62a to 9c92b4c Compare December 30, 2024 16:49
@gmuloc gmuloc merged commit 817eeb8 into devel Jan 3, 2025
43 checks passed
@gmuloc gmuloc deleted the pre-commit-ci-update-config branch January 3, 2025 15:56
@github-actions github-actions bot added the rn: CI label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants