-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add uplink_interface_speed
option for default_interfaces
#4828
Feat(eos_designs): Add uplink_interface_speed
option for default_interfaces
#4828
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4828
# Activate the virtual environment
source test-avd-pr-4828/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/eos_designs/default_interface_speed#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/eos_designs/default_interface_speed --force
# Optional: Install AVD examples
cd test-avd-pr-4828
ansible-playbook arista.avd.install_examples |
bc6d00e
to
5a97870
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
5a97870
to
47feef6
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
python-avd/pyavd/_eos_designs/schema/schema_fragments/default_interfaces.schema.yml
Show resolved
Hide resolved
Co-authored-by: Shivani-gslab <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@pvinci-arista this is ready ;) |
Change Summary
Add
uplink_interface_speed
option fordefault_interfaces
Related Issue(s)
Fixes #4639
Component(s) name
arista.avd.eos_designs
Proposed changes
When using the default_interfaces: model, it makes sense to also be able to define corresponding interface speed.
How to test
Checklist
User Checklist
Repository Checklist