Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add uplink_interface_speed option for default_interfaces #4828

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Dec 18, 2024

Change Summary

Add uplink_interface_speed option for default_interfaces

Related Issue(s)

Fixes #4639

Component(s) name

arista.avd.eos_designs

Proposed changes

When using the default_interfaces: model, it makes sense to also be able to define corresponding interface speed.

default_interfaces:
  - types: [ l3leaf ]
    platforms: [ 720XP-48 ]
    uplink_interfaces: [ Ethernet53/1, Ethernet54/1 ]
    uplink_speed: forced 100G

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Dec 18, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4828
# Activate the virtual environment
source test-avd-pr-4828/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/eos_designs/default_interface_speed#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/eos_designs/default_interface_speed --force
# Optional: Install AVD examples
cd test-avd-pr-4828
ansible-playbook arista.avd.install_examples

@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/eos_designs/default_interface_speed branch 2 times, most recently from bc6d00e to 5a97870 Compare December 18, 2024 16:37
@Shivani-gslab Shivani-gslab marked this pull request as ready for review December 20, 2024 06:37
@Shivani-gslab Shivani-gslab requested review from a team as code owners December 20, 2024 06:37
@MaheshGSLAB MaheshGSLAB marked this pull request as draft December 20, 2024 06:49
@github-actions github-actions bot added the state: conflict PR with conflict label Dec 20, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/eos_designs/default_interface_speed branch from 5a97870 to 47feef6 Compare December 23, 2024 09:03
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 23, 2024
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shivani-gslab Shivani-gslab marked this pull request as ready for review December 24, 2024 13:27
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jan 3, 2025
@gmuloc
Copy link
Contributor

gmuloc commented Jan 3, 2025

@pvinci-arista this is ready ;)

@gmuloc gmuloc merged commit 2b7b580 into aristanetworks:devel Jan 3, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Add speed option for default_interfaces
4 participants