-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Additional interface TE options #4823
Merged
gmuloc
merged 12 commits into
aristanetworks:devel
from
emilarista:feat/eos_cli_config_gen/interface-additional-te-knobs
Jan 14, 2025
Merged
Feat(eos_cli_config_gen): Additional interface TE options #4823
gmuloc
merged 12 commits into
aristanetworks:devel
from
emilarista:feat/eos_cli_config_gen/interface-additional-te-knobs
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Dec 17, 2024
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4823
# Activate the virtual environment
source test-avd-pr-4823/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/emilarista/ansible-avd.git@feat/eos_cli_config_gen/interface-additional-te-knobs#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/emilarista/ansible-avd.git#/ansible_collections/arista/avd/,feat/eos_cli_config_gen/interface-additional-te-knobs --force
# Optional: Install AVD examples
cd test-avd-pr-4823
ansible-playbook arista.avd.install_examples |
ClausHolbechArista
requested changes
Jan 6, 2025
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Jan 14, 2025
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/ethernet-interfaces.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
…umentation/devices/host1.md
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
…/port-channel-interfaces.j2
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/port-channel-interfaces.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Jan 14, 2025
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Jan 14, 2025
gmuloc
requested changes
Jan 14, 2025
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/port_channel_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
gmuloc
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI reruns after pre-commit does its work
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Implements additional interface TE options.
Also removes unnecessary doc template column added in #4754 for traffic_engineering.enabled which is already implied by the interface being added to the table (single criteria for appending to the list of interfaces is traffic_engineering.enabled == true). This would just be a column of all True values.
Related Issue(s)
Fixes part of #https://github.com/aristanetworks/avd-internal/issues/149
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Tested with molecule and on device.
Checklist
Repository Checklist