Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): sflow_polling_interval #4820

Conversation

ernestoherrerab
Copy link
Contributor

Change Summary

Adds the option to modify the polling interval for sflow_settings.

Related Issue(s)

Fixes #4813

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Updated sflow_settings schema
  • Updated SflowSettings class
  • Updated eos_designs documentation
sflow_settings:
  polling_interval: 1

How to test

Tested with molecule and on a vEOS lab.

Checklist

Repository Checklist

  • [ X] My code has been rebased from devel before I start
  • [ X] I have read the CONTRIBUTING document.
  • [ X] My change requires a change to the documentation and documentation have been updated accordingly.
  • [ X] I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4820
# Activate the virtual environment
source test-avd-pr-4820/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ernestoherrerab/avd.git@feat/eos_designs/sflow_polling_interval#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ernestoherrerab/avd.git#/ansible_collections/arista/avd/,feat/eos_designs/sflow_polling_interval --force
# Optional: Install AVD examples
cd test-avd-pr-4820
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Dec 17, 2024
@ernestoherrerab ernestoherrerab changed the title Feat(eos_designs):sflow_polling_interval Feat(eos_designs): sflow_polling_interval Dec 17, 2024
@ernestoherrerab ernestoherrerab marked this pull request as ready for review December 17, 2024 10:55
@ernestoherrerab ernestoherrerab requested review from a team as code owners December 17, 2024 10:55
@gmuloc gmuloc requested a review from a team December 17, 2024 11:14
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Dec 17, 2024
@gmuloc gmuloc merged commit 3647e85 into aristanetworks:devel Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Add polling interval knob for sflow_settings in eos_designs
3 participants