Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Fix wrong variable used in eos\stun.j2 #4814

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Dec 16, 2024

Change Summary

Fix wrong variable used in eos\stun.j2.

Wrong variable in eos/stun.j2

{% elif stun.server.ssl_connection_lifetime.hours is arista.avd.defined %}
ssl connection lifetime {{ stun.segitrver.ssl_connection_lifetime.hours }} hours >>>
{% endif %}

The variable should be stun.server.ssl_connection_lifetime.hours instead of stun.segitrver.ssl_connection_lifetime.hours.

Related Issue(s)

Fixes #4808

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Fix wrong variable used in eos\stun.j2.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4814
# Activate the virtual environment
source test-avd-pr-4814/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@bug/stun#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,bug/stun --force
# Optional: Install AVD examples
cd test-avd-pr-4814
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 16, 2024
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review December 18, 2024 04:58
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners December 18, 2024 04:58
@MaheshGSLAB MaheshGSLAB requested a review from a team December 18, 2024 05:00
@gmuloc gmuloc merged commit eba713c into aristanetworks:devel Dec 18, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(eos_cli_config_gen): Wrong variable in eos/stun.j2
3 participants