Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Added support to set RCF for peer group in router bgp address family IPv4/IPv6 #4804

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Added support to set RCF for peer group in router bgp address family IPv4/IPv6

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

Added support to set RCF for peer group in router bgp address family IPv4/IPv6. Same as route_map in/out added support for rcf in/out for BGP peer groups under address family IPv4/IPv6.

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Dec 11, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4804
# Activate the virtual environment
source test-avd-pr-4804/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-2397#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-2397 --force
# Optional: Install AVD examples
cd test-avd-pr-4804
ansible-playbook arista.avd.install_examples

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review December 13, 2024 06:56
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners December 13, 2024 06:56
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaheshGSLAB MaheshGSLAB requested a review from a team December 13, 2024 07:37
@ClausHolbechArista ClausHolbechArista merged commit 7e5b9c4 into aristanetworks:devel Dec 13, 2024
43 checks passed
emilarista pushed a commit to emilarista/ansible-avd that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants