Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Added support for use different router IDs per VRF defined in network services #4775

Open
wants to merge 13 commits into
base: devel
Choose a base branch
from

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Added support for use different router IDs per VRF defined in network services

Related Issue(s)

Fixes #2643

Component(s) name

arista.avd.eos_designs

Proposed changes

Added support for use different router IDs per VRF defined in network services.

vrfs:
      - name: myvrf
        bgp:
          # Router ID to use for BGP in this VRF.
          # This can be an IP address, "main_router_id", "none", "vtep_diagnostic"
          # - "use_main_router_id" will reuse the main BGP Router ID which is the IP address of Loopback0.
          # - "none" will not configure a BGP Router ID for this VRF. EOS will use the main BGP Router ID. <--- TODO: Verify this.
          # - "vtep_diagnostic" will use the IP address of the VRF Diagnostic Loopback interface.
          router_id: <str; default="main_router_id">
        ospf:
          router_id: <same>

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Dec 3, 2024
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4775
# Activate the virtual environment
source test-avd-pr-4775/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-2643#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-2643 --force
# Optional: Install AVD examples
cd test-avd-pr-4775
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Dec 3, 2024
@MaheshGSLAB MaheshGSLAB changed the title Feat(eos_designs): Added support for use different router IDs per VRF defined in network services(WIP) Feat(eos_designs): Added support for use different router IDs per VRF defined in network services Dec 3, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review December 10, 2024 08:05
@laxmikantchintakindi laxmikantchintakindi requested review from a team as code owners December 10, 2024 08:05
@MaheshGSLAB MaheshGSLAB requested a review from gmuloc December 11, 2024 14:01
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One cosmetic comment on docstring but I think this PR is ready after that

@github-actions github-actions bot added the state: conflict PR with conflict label Dec 20, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 31, 2024
Copy link

github-actions bot commented Jan 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jan 2, 2025
@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

expected_error_message: >-
Invalid configuration on VRF 'Tenant_X_OP_Zone' in Tenant 'Tenant_X'.
'vtep_diagnostic.loopback' along with either 'vtep_diagnostic.loopback_ip_pools' or 'vtep_diagnostic.loopback_ip_range' must be defined
when 'router_id' is set to 'vtep_diagnostic' on the VRF.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message also needs to be updated with the new wording.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to Use Different Router IDs per VRF defined in Network Services
4 participants