Feat(eos_cli_config_gen): Add support for ip name server groups #4763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4763
# Activate the virtual environment
source test-avd-pr-4763/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/eos_cli/ip-name-server-group#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/eos_cli/ip-name-server-group --force
# Optional: Install AVD examples
cd test-avd-pr-4763
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
laxmikantchintakindi
force-pushed
the
feat/eos_cli/ip-name-server-group
branch
6 times, most recently
from
13bff48 to
52d9f5a
Compare
gmuloc
reviewed
Nov 27, 2024
| @@ -5,7 +5,7 @@ | |||
| # Line above is used by RedHat's YAML Schema vscode extension | |||
| # Use Ctrl + Space to get suggestions for every field. Autocomplete will pop up after typing 2 letters. | |||
| type: dict | |||
| keys: | |||
| $defs: | |||
There was a problem hiding this comment.
add default: default on the vrf to document what you are doing in the templates
There was a problem hiding this comment.
Removed this defs and added all the keys in ip_name_server_groups schema with default vrf default.
There was a problem hiding this comment.
I guess the reason for this (==removing the defs) was because we are not currently injecting default for ip name-servers ?
There was a problem hiding this comment.
ok thanks
seems that default: default would make sense for the other one as well:
site3-leaf1(config-if-Et4)#ip name-server 1.1.1.1
site3-leaf1(config)#show run se name-ser
ip name-server vrf MGMT 10.14.0.1
ip name-server vrf MGMT 192.168.17.1
ip name-server vrf default 1.1.1.1
but that would be a breaking change in terms of what we produce as the current template does not inject VRF default. so we can revisit this later.
Can you please open an issue to track this?
laxmikantchintakindi
force-pushed
the
feat/eos_cli/ip-name-server-group
branch
from
3e14cbf to
ae1ef81
Compare
MaheshGSLAB
reviewed
Nov 29, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ip-name-server-groups.j2
Outdated
Show resolved
Hide resolved
...s/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/ip_name_server_groups.yml
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
feat/eos_cli/ip-name-server-group
branch
3 times, most recently
from
fd9d66f to
37daa62
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
laxmikantchintakindi
force-pushed
the
feat/eos_cli/ip-name-server-group
branch
from
3fa7b5e to
69ae148
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Vibhu-gslab
force-pushed
the
feat/eos_cli/ip-name-server-group
branch
from
69ae148 to
f555179
Compare
Vibhu-gslab
reviewed
Dec 3, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ip-name-server-groups.j2
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Dec 3, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Outdated
Show resolved
Hide resolved
github-actions
bot
added
role: eos_validate_state
role: dhcp_provisioner
type: Python filters
role: eos_snapshot
role: eos_designs
Vibhu-gslab
previously approved these changes
Jan 2, 2025
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
type: documentation
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add support for ip name server groups
Related Issue(s)
Fixes #4698
Component(s) name
arista.avd.eos_cli_config_genProposed changes
There is no input variable for applying the ip name-server group to monitor connectivity via eos_cli_config_gen. Below contains the use cause example.
ip name-server group {name_server_group}
name-server vrf {name_server_vrf} {IP}
monitor connectivity
vrf {name_server_vrf}
interface set {set_name} {loopback_name}
description {description}
!
host {host_name}
url {url}
name-server group {name_server_group}
How to test
Checklist
User Checklist
Repository Checklist