Refactor(eos_cli_config_gen): Update eos template to validate type key defined in aaa_server_group model
#4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4748
# Activate the virtual environment
source test-avd-pr-4748/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/eos_cli/aaa_server_group_type_key#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/eos_cli/aaa_server_group_type_key --force
# Optional: Install AVD examples
cd test-avd-pr-4748
ansible-playbook arista.avd.install_examples |
ClausHolbechArista
previously requested changes
Nov 21, 2024
github-actions
bot
removed
role: eos_cli_config_gen
|
laxmikantchintakindi
changed the title
type key required in aaa_server_group modeltype key defined in aaa_server_group model
MaheshGSLAB
reviewed
Nov 25, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/aaa-server-groups-tacacs-plus.j2
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
refactor/eos_cli/aaa_server_group_type_key
branch
from
8b1eb8d to
f2bb622
Compare
laxmikantchintakindi
requested review from
MaheshGSLAB,
Vibhu-gslab and
Shivani-gslab
Vibhu-gslab
force-pushed
the
refactor/eos_cli/aaa_server_group_type_key
branch
from
f2bb622 to
6a51d1f
Compare
Vibhu-gslab
requested changes
Nov 27, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/aaa-server-groups-ldap.j2
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
refactor/eos_cli/aaa_server_group_type_key
branch
from
90e23ed to
6a23b79
Compare
MaheshGSLAB
reviewed
Dec 2, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/aaa-server-groups.j2
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
refactor/eos_cli/aaa_server_group_type_key
branch
from
d6e0f9e to
1e6511a
Compare
MaheshGSLAB
reviewed
Dec 3, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/aaa-server-groups-ldap.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/aaa-server-groups-radius.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/aaa-server-groups-tacacs-plus.j2
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
state: CI Updated
gmuloc
reviewed
Dec 4, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/aaa-server-groups-tacacs-plus.j2
Outdated
Show resolved
Hide resolved
MaheshGSLAB
approved these changes
Dec 6, 2024
laxmikantchintakindi
force-pushed
the
refactor/eos_cli/aaa_server_group_type_key
branch
from
35cf4e0 to
01e5fc0
Compare
for more information, see https://pre-commit.ci
Vibhu-gslab
force-pushed
the
refactor/eos_cli/aaa_server_group_type_key
branch
from
01e5fc0 to
f1cad46
Compare
Vibhu-gslab
previously requested changes
Dec 10, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/aaa-server-groups.j2
Show resolved
Hide resolved
gmuloc
approved these changes
Dec 11, 2024
gmuloc
dismissed
ClausHolbechArista’s stale review
comment addressed - no required key in schema (for now ..)
emilarista
pushed a commit
to emilarista/ansible-avd
that referenced
this pull request
Dec 17, 2024
…key defined in `aaa_server_group` model (aristanetworks#4748)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor
aaa_server_grouptemplates.Related Issue(s)
Fixes #4650
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Make
typekey required inaaa_server_groupmodel.How to test
Checklist
User Checklist
Repository Checklist