-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(plugins): Set changed=true and print yellow updates when recompiling schemas/templates #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling schemas/templates
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4715
# Activate the virtual environment
source test-avd-pr-4715/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/4709#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/4709 --force
# Optional: Install AVD examples
cd test-avd-pr-4715
ansible-playbook arista.avd.install_examples |
gmuloc
commented
Nov 12, 2024
alexeygorbunov
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ClausHolbechArista
requested changes
Nov 13, 2024
ClausHolbechArista
approved these changes
Nov 13, 2024
gmuloc
added
one approval
This PR has one approval and is only missing one more.
and removed
one approval
This PR has one approval and is only missing one more.
labels
Nov 13, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
1/ set changed=true
2/ if any templates or schemas was recompiled print a yellow log.
Related Issue(s)
Fixes #4709
Component(s) name
plugins
Proposed changes
cf summary
How to test
remove the
.hash
files inpython-avd/pyavd/*/j2templates
andpython-avd/pyavd/*/schema/schema_fragments/
and run any moleculeNo verbosity:
Verbosity 1:
Checklist
Repository Checklist