Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(plugins): Set changed=true and print yellow updates when recompiling schemas/templates #4715

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Nov 12, 2024

Change Summary

1/ set changed=true
2/ if any templates or schemas was recompiled print a yellow log.

Related Issue(s)

Fixes #4709

Component(s) name

plugins

Proposed changes

cf summary

How to test

remove the .hash files in python-avd/pyavd/*/j2templates and python-avd/pyavd/*/schema/schema_fragments/ and run any molecule

No verbosity:

Screenshot 2024-11-12 at 15 28 13

Verbosity 1:

Screenshot 2024-11-12 at 15 27 43

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4715
# Activate the virtual environment
source test-avd-pr-4715/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/4709#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/4709 --force
# Optional: Install AVD examples
cd test-avd-pr-4715
ansible-playbook arista.avd.install_examples

@gmuloc gmuloc marked this pull request as ready for review November 12, 2024 14:29
@gmuloc gmuloc requested review from a team as code owners November 12, 2024 14:29
Copy link
Contributor

@alexeygorbunov alexeygorbunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc added one approval This PR has one approval and is only missing one more. and removed one approval This PR has one approval and is only missing one more. labels Nov 13, 2024
@gmuloc gmuloc merged commit 24a97d2 into aristanetworks:devel Nov 13, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate_requirements: Set changed=true and print yellow updates when recompiling schemas/templates
3 participants