Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add maximum_paths to router_bgp.vrfs #4655

Merged
merged 26 commits into from
Oct 28, 2024

Conversation

juanjtomasg
Copy link
Contributor

Change Summary

Add maximum_paths for router_bgp.vrfs

Related Issue(s)

Fixes #4583

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add support for maximum_paths per vrf within router_bgp:

router_bgp:

  vrfs:
    maximum_paths:
        paths: <int; 1-600; required>
        ecmp: <int; 1-600>

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • [ X] My code has been rebased from devel before I start
  • [X ] I have read the CONTRIBUTING document.
  • [X ] My change requires a change to the documentation and documentation have been updated accordingly.
  • [X ] I have updated molecule CI testing accordingly. (check the box if not applicable)

@juanjtomasg juanjtomasg requested review from a team as code owners October 25, 2024 15:11
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4655
# Activate the virtual environment
source test-avd-pr-4655/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/juanjtomasg/avd.git@feat/bgp_vrf_maximum_paths#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/juanjtomasg/avd.git#/ansible_collections/arista/avd/,feat/bgp_vrf_maximum_paths --force
# Optional: Install AVD examples
cd test-avd-pr-4655
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 25, 2024
@juanjtomasg juanjtomasg changed the title Feat/bgp vrf maximum paths Feat(eos_cli_config_gen): bgp vrf maximum paths Oct 26, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the feat/bgp_vrf_maximum_paths branch from b2fa0a8 to be1dacb Compare October 28, 2024 09:06
@gmuloc gmuloc changed the title Feat(eos_cli_config_gen): bgp vrf maximum paths Feat(eos_cli_config_gen): Add maximum_paths to router_bgp.vrfs Oct 28, 2024
Copy link

Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmuloc gmuloc merged commit e8be905 into aristanetworks:devel Oct 28, 2024
45 checks passed
@gmuloc
Copy link
Contributor

gmuloc commented Oct 28, 2024

Thanks @juanjtomasg for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router bgp - missing maximum-paths within vrf section
4 participants