-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add maximum_paths to router_bgp.vrfs #4655
Merged
gmuloc
merged 26 commits into
aristanetworks:devel
from
juanjtomasg:feat/bgp_vrf_maximum_paths
Oct 28, 2024
Merged
Feat(eos_cli_config_gen): Add maximum_paths to router_bgp.vrfs #4655
gmuloc
merged 26 commits into
aristanetworks:devel
from
juanjtomasg:feat/bgp_vrf_maximum_paths
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4655
# Activate the virtual environment
source test-avd-pr-4655/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/juanjtomasg/avd.git@feat/bgp_vrf_maximum_paths#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/juanjtomasg/avd.git#/ansible_collections/arista/avd/,feat/bgp_vrf_maximum_paths --force
# Optional: Install AVD examples
cd test-avd-pr-4655
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Oct 25, 2024
for more information, see https://pre-commit.ci
juanjtomasg
changed the title
Feat/bgp vrf maximum paths
Feat(eos_cli_config_gen): bgp vrf maximum paths
Oct 26, 2024
Vibhu-gslab
reviewed
Oct 28, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
Vibhu-gslab
force-pushed
the
feat/bgp_vrf_maximum_paths
branch
from
October 28, 2024 09:06
b2fa0a8
to
be1dacb
Compare
MaheshGSLAB
reviewed
Oct 28, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml
Show resolved
Hide resolved
gmuloc
changed the title
Feat(eos_cli_config_gen): bgp vrf maximum paths
Feat(eos_cli_config_gen): Add maximum_paths to router_bgp.vrfs
Oct 28, 2024
Quality Gate passedIssues Measures |
MaheshGSLAB
approved these changes
Oct 28, 2024
Vibhu-gslab
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gmuloc
approved these changes
Oct 28, 2024
gmuloc
approved these changes
Oct 28, 2024
Thanks @juanjtomasg for this contribution! |
gmuloc
pushed a commit
to gmuloc/avd
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add
maximum_paths
forrouter_bgp.vrfs
Related Issue(s)
Fixes #4583
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Add support for maximum_paths per vrf within router_bgp:
How to test
Checklist
User Checklist
Repository Checklist