Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert(eos_designs): Remove legacy autovpn with new plan for when AutoVPN 2.0 gets out #4652

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 25, 2024

Change Summary

cf title

Component(s) name

arista.avd.eos_designs

Proposed changes

removing all the changes

How to test

molecule should pass

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 25, 2024 12:51
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4652
# Activate the virtual environment
source test-avd-pr-4652/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@revert-legacy-autovpn#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,revert-legacy-autovpn --force
# Optional: Install AVD examples
cd test-avd-pr-4652
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 25, 2024
@gmuloc gmuloc added this to the v5.0.0 milestone Oct 25, 2024
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 25, 2024
@github-actions github-actions bot removed the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Oct 25, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if CI passes!

Copy link

@ClausHolbechArista ClausHolbechArista merged commit a8aea88 into aristanetworks:devel Oct 25, 2024
41 checks passed
gmuloc added a commit to gmuloc/avd that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Revert(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants