Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump: Add support for Python3.13 #4651

Merged

Conversation

ClausHolbechArista
Copy link
Contributor

Add support for Python3.13

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners October 25, 2024 12:13
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4651
# Activate the virtual environment
source test-avd-pr-4651/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@bump/python3.13#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,bump/python3.13 --force
# Optional: Install AVD examples
cd test-avd-pr-4651
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the type: code quality CI and development toolset label Oct 25, 2024
Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmuloc
gmuloc previously approved these changes Oct 25, 2024
@gmuloc gmuloc self-requested a review October 25, 2024 12:57
@gmuloc gmuloc dismissed their stale review October 25, 2024 12:58

Need to have it pass

Copy link

@ClausHolbechArista ClausHolbechArista merged commit 02a3040 into aristanetworks:devel Oct 25, 2024
50 checks passed
gmuloc pushed a commit to gmuloc/avd that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Bump type: code quality CI and development toolset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants