Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Added dot1x radius av-pair lldp and dhcp command support #4618

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB commented Oct 21, 2024

Change Summary

Added dot1x radius av-pair lldp and dhcp command support

Related Issue(s)

Fixes #4577

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added dot1x radius av-pair lldp and dhcp command support

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Oct 21, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4618
# Activate the virtual environment
source test-avd-pr-4618/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4577#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4577 --force
# Optional: Install AVD examples
cd test-avd-pr-4618
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 21, 2024
@MaheshGSLAB MaheshGSLAB changed the title Feat(eos_cli_config_gen): Added dot1x radius av-pair lldp and 'dhcp' command support Feat(eos_cli_config_gen): Added dot1x radius av-pair lldp and dhcp command support Oct 21, 2024
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review October 24, 2024 04:52
@laxmikantchintakindi laxmikantchintakindi requested review from a team as code owners October 24, 2024 04:52
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until 5.0 was released

@ClausHolbechArista ClausHolbechArista dismissed their stale review October 28, 2024 08:13

5.0 is out so this can be reviewed and merged

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 28, 2024
Copy link

@gmuloc gmuloc merged commit 2b115f7 into aristanetworks:devel Oct 28, 2024
45 checks passed
gmuloc pushed a commit to gmuloc/avd that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for additional dot1x commands
5 participants