-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Improve ptp
settings for p2p_links
#4612
Feat(eos_designs): Improve ptp
settings for p2p_links
#4612
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4612
# Activate the virtual environment
source test-avd-pr-4612/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/ptp-p2p-links#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/ptp-p2p-links --force
# Optional: Install AVD examples
cd test-avd-pr-4612
ansible-playbook arista.avd.install_examples |
ptp
settings for p2p_links
ptp
settings for p2p_links
python-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/utils.py
Show resolved
Hide resolved
5504ee0
to
3477fa5
Compare
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_p2p_links.schema.yml
Outdated
Show resolved
Hide resolved
...-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_p2p_links.schema.yml
Outdated
Show resolved
Hide resolved
...llections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/custom-ptp-profile.cfg
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test coverage in eos_designs_unit_tests
scenario
cf1360c
to
6b67c93
Compare
Added. |
6b67c93
to
fee17c7
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
fee17c7
to
de3c1d7
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ab63faf
to
50527f8
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions to refactor after the rebase.
python-avd/pyavd/_eos_designs/structured_config/connected_endpoints/utils.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/utils.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/utils.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/utils.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/utils.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/utils.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/utils.py
Outdated
Show resolved
Hide resolved
6fa42c7
to
e4ed51c
Compare
to prevent merging before the rebase changes are checked
...le_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/PTP_TESTS.yml
Show resolved
Hide resolved
Tests have been added, so dismissing the stale review.
Change Summary
Improve
ptp
settings forp2p_links
Related Issue(s)
Fixes #2698
Component(s) name
arista.avd.eos_designs
Proposed changes
PTP knobs are available in connected_endpoints:
These would be valuable to have also in l3_edge p2p_links for L3 devices.
How to test
Checklist
User Checklist
Repository Checklist