-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add vrf support for vmtracer_sessions #4601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Oct 16, 2024
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4601
# Activate the virtual environment
source test-avd-pr-4601/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@vmtracer#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,vmtracer --force
# Optional: Install AVD examples
cd test-avd-pr-4601
ansible-playbook arista.avd.install_examples |
MaheshGSLAB
approved these changes
Oct 16, 2024
laxmikantchintakindi
approved these changes
Oct 16, 2024
ClausHolbechArista
previously requested changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking to not merge to 5.0
ClausHolbechArista
dismissed
their stale review
October 28, 2024 08:07
5.0 is out so this can be reviewed and merged
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Oct 28, 2024
gmuloc
reviewed
Oct 28, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/vmtracer-sessions.j2
Outdated
Show resolved
Hide resolved
gmuloc
approved these changes
Oct 28, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add vrf support for vmtracer_sessions
Related Issue(s)
Fixes #4360
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Test added in molecule. Check the EOS CLI.
Checklist
User Checklist
Repository Checklist