Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add vrf support for vmtracer_sessions #4601

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Oct 16, 2024

Change Summary

Add vrf support for vmtracer_sessions

Related Issue(s)

Fixes #4360

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

vmtracer_sessions:
        # Vmtracer Session Name.
      - name: <str; required; unique>
        vrf: <str>

How to test

Test added in molecule. Check the EOS CLI.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 16, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4601
# Activate the virtual environment
source test-avd-pr-4601/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@vmtracer#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,vmtracer --force
# Optional: Install AVD examples
cd test-avd-pr-4601
ansible-playbook arista.avd.install_examples

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review October 16, 2024 07:06
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners October 16, 2024 07:06
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking to not merge to 5.0

@ClausHolbechArista ClausHolbechArista added this to the v5.1.0-dev1 milestone Oct 16, 2024
@ClausHolbechArista ClausHolbechArista dismissed their stale review October 28, 2024 08:07

5.0 is out so this can be reviewed and merged

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 28, 2024
Copy link

@gmuloc gmuloc merged commit f5fa416 into aristanetworks:devel Oct 28, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vrf support for vmtracer_sessions
5 participants