Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Rearrange the eos-cli config for tap-aggregation to match with EOS #4585

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Oct 11, 2024

Change Summary

Rearrange the eos-cli config for tap-aggregation to match with EOS

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4585
# Activate the virtual environment
source test-avd-pr-4585/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@tap-aggregation#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,tap-aggregation --force
# Optional: Install AVD examples
cd test-avd-pr-4585
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 11, 2024
@Shivani-gslab Shivani-gslab added this to the v5.0.0 milestone Oct 11, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review October 11, 2024 14:13
@Shivani-gslab Shivani-gslab requested review from a team as code owners October 11, 2024 14:13
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 11, 2024
Copy link
Contributor

@alexeygorbunov alexeygorbunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (confirmed with DCS-7280SR2/4.32.2F)

Copy link

@carlbuchmann carlbuchmann merged commit 49f25bf into aristanetworks:devel Oct 11, 2024
43 checks passed
nathanmusser pushed a commit to nathanmusser/avd that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants