Fix(eos_cli_config_gen): Fix the maximum-routes, next-hop resolution v4-mapped-v6 translation commands in router_bgp.address_family_ipv4_labeled_unicast
#4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4567
# Activate the virtual environment
source test-avd-pr-4567/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@bug-router-bgp#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,bug-router-bgp --force
# Optional: Install AVD examples
cd test-avd-pr-4567
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
Vibhu-gslab
added
the
one approval
ClausHolbechArista
requested changes
Oct 10, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
|
ClausHolbechArista
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix the maximum-routes, next-hop resolution v4-mapped-v6 translation commands in
router_bgp.address_family_ipv4_labeled_unicastand removed the j2 logic for redistribute rip fromrouter_bgp.address_family_ipv6Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Fix the maximum-routes, next-hop resolution v4-mapped-v6 translation commands in
router_bgp.address_family_ipv4_labeled_unicastand removed the j2 logic for redistribute rip fromrouter_bgp.address_family_ipv6How to test
Run molecule
Checklist
User Checklist
Repository Checklist