-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Rearrange the eos-cli config for router-bgp to match with EOS #4566
Refactor(eos_cli_config_gen): Rearrange the eos-cli config for router-bgp to match with EOS #4566
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4566
# Activate the virtual environment
source test-avd-pr-4566/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@router-bgp-order#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,router-bgp-order --force
# Optional: Install AVD examples
cd test-avd-pr-4566
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
router_bgp.vlans
should be sorted based on id
Line- 501 in router-bgp.j2
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
updated the j2 logic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked all the commands
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked that there is no missing rendered CLI post reordering
Checked most of the templates (blocks moved in correct place and no missing block) - could have missed something but this looks pretty good to me.
…-bgp to match with EOS (aristanetworks#4566)
Change Summary
Rearrange the eos-cli config for router-bgp to match with EOS
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Rearrange the eos-cli config for router-bgp to match with EOS
How to test
Run molecule
Checklist
User Checklist
Repository Checklist