Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Rearrange the eos-cli config for router-bgp to match with EOS #4566

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Rearrange the eos-cli config for router-bgp to match with EOS

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Rearrange the eos-cli config for router-bgp to match with EOS

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB added this to the v5.0.0 milestone Oct 9, 2024
@MaheshGSLAB MaheshGSLAB self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4566
# Activate the virtual environment
source test-avd-pr-4566/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@router-bgp-order#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,router-bgp-order --force
# Optional: Install AVD examples
cd test-avd-pr-4566
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 9, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review October 9, 2024 11:16
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners October 9, 2024 11:16
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

router_bgp.vlans should be sorted based on id
Line- 501 in router-bgp.j2

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Oct 10, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 10, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@MaheshGSLAB
Copy link
Contributor Author

router_bgp.vlans should be sorted based on id Line- 501 in router-bgp.j2

updated the j2 logic

Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked all the commands

Copy link

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that there is no missing rendered CLI post reordering
Checked most of the templates (blocks moved in correct place and no missing block) - could have missed something but this looks pretty good to me.

@ClausHolbechArista ClausHolbechArista merged commit 7e95681 into aristanetworks:devel Oct 11, 2024
43 checks passed
nathanmusser pushed a commit to nathanmusser/avd that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Refactor(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants