Refactor(eos_cli_config_gen): Improved redistribute data models under router_bgp #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4550
# Activate the virtual environment
source test-avd-pr-4550/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@redistribute-cli-gen#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,redistribute-cli-gen --force
# Optional: Install AVD examples
cd test-avd-pr-4550
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
...sta/avd/molecule/eos_cli_config_gen/documentation/devices/router-bgp-vrf-address-families.md
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Vibhu-gslab
previously requested changes
Oct 8, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
..._collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/router-bgp-evpn.md
Outdated
Show resolved
Hide resolved
...sta/avd/molecule/eos_cli_config_gen/documentation/devices/router-bgp-vrf-address-families.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
type: documentation
...sta/avd/molecule/eos_cli_config_gen/documentation/devices/router-bgp-vrf-address-families.md
Show resolved
Hide resolved
laxmikantchintakindi
approved these changes
Oct 9, 2024
ClausHolbechArista
changed the title
ClausHolbechArista
approved these changes
Oct 10, 2024
ClausHolbechArista
dismissed
Vibhu-gslab’s stale review
requested changes have been implemented.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Changed the redistribute routes data model from list of dict(redistribute_routes) to dict of dict(redistribute).
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Deprecating old redistribute_routes data model and adding new dict of dict redistribute data model
How to test
Run the molecule
Checklist
User Checklist
Repository Checklist