-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Rearrange eos_cli_config_gen commands to match with EOS sequence - Part 5 #4549
Merged
ClausHolbechArista
merged 18 commits into
aristanetworks:devel
from
laxmikantchintakindi:refactor/eos_cli_sequence4
Oct 11, 2024
Merged
Refactor(eos_cli_config_gen): Rearrange eos_cli_config_gen commands to match with EOS sequence - Part 5 #4549
ClausHolbechArista
merged 18 commits into
aristanetworks:devel
from
laxmikantchintakindi:refactor/eos_cli_sequence4
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4549
# Activate the virtual environment
source test-avd-pr-4549/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/eos_cli_sequence4#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/eos_cli_sequence4 --force
# Optional: Install AVD examples
cd test-avd-pr-4549
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Oct 4, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/ip-nat.cfg
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
refactor/eos_cli_sequence4
branch
from
October 4, 2024 07:23
7646565
to
4d7e9fe
Compare
Vibhu-gslab
reviewed
Oct 7, 2024
..._collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/ethernet-interfaces.cfg
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-ospf.j2
Outdated
Show resolved
Hide resolved
laxmikantchintakindi
force-pushed
the
refactor/eos_cli_sequence4
branch
from
October 9, 2024 08:41
68b5c05
to
240e30c
Compare
MaheshGSLAB
reviewed
Oct 9, 2024
MaheshGSLAB
approved these changes
Oct 9, 2024
laxmikantchintakindi
force-pushed
the
refactor/eos_cli_sequence4
branch
from
October 9, 2024 11:35
7af47d8
to
e0d39c1
Compare
Shivani-gslab
approved these changes
Oct 9, 2024
ClausHolbechArista
approved these changes
Oct 11, 2024
Quality Gate passedIssues Measures |
ClausHolbechArista
merged commit Oct 11, 2024
ede588d
into
aristanetworks:devel
42 of 43 checks passed
nathanmusser
pushed a commit
to nathanmusser/avd
that referenced
this pull request
Oct 16, 2024
…o match with EOS sequence - Part 5 (aristanetworks#4549)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Rearrange eos_cli_config_gen commands to match with EOS sequence - Part 5
Templates
router-ospf
andinterface-ip-nat
androles
have been touched in this PR.Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Checklist
User Checklist
Repository Checklist