Refactor(eos_designs): Setting ospf.area default values to 0.0.0.0

[Shivani-gslab]

Change Summary

OSPF default values should default to "0.0.0.0" since that is how EOS translates "0"

Related Issue(s)

Fixes #3006

Component(s) name

arista.avd.eos_designs

Proposed changes

Setting ospf.area default values to 0.0.0.0 in schema and code.

How to test

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4536
# Activate the virtual environment
source test-avd-pr-4536/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@ospf_default_to_0.0.0.0#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,ospf_default_to_0.0.0.0 --force
# Optional: Install AVD examples
cd test-avd-pr-4536
ansible-playbook arista.avd.install_examples

[gmuloc]

@Shivani-gslab we have a couple of places in our molecule scenarios where the value was hardcoded to 0 for area under tenants:

./eos_designs-mpls-isis-sr-ldp/inventory/group_vars/MPLS_TENANTS_NETWORKS.yml:              area: 0
./eos_designs-mpls-isis-sr-ldp/inventory/group_vars/MPLS_TENANTS_NETWORKS.yml:              area: 0
./eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml:              area: 0
./eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml:              area: 0
./eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml:              area: 0

I think for the sake of them being example it would be best to update them to 0.0.0.0 in this PR.

[alexeygorbunov]

./ansible_collections/arista/avd/molecule/eos_designs-mpls-isis-sr-ldp/documentation/devices/SITE1-LER1.md

285: ip ospf area 0
600:| Ethernet6.100 | 0 | 10 | True |

[Shivani-gslab]

./ansible_collections/arista/avd/molecule/eos_designs-mpls-isis-sr-ldp/documentation/devices/SITE1-LER1.md

285: ip ospf area 0 600:| Ethernet6.100 | 0 | 10 | True |

it is provided as input here and is not generated by default - https://github.com/aristanetworks/avd/blob/devel/ansible_collections/arista/avd/molecule/eos_designs-mpls-isis-sr-ldp/inventory/group_vars/MPLS_TENANTS_NETWORKS.yml#L79

[ClausHolbechArista]

@gmuloc @alexeygorbunov To be clear, we still need to test that giving ospf area 0 still works. So it is ok to have molecule vars with area 0. It is just the default we are changing.

[sonarqubecloud]

Please retry analysis of this Pull-Request directly on SonarCloud

[ClausHolbechArista]

Guillaume told me we have some test with another integer area, so that we can keep that and then change all the 0 -> 0.0.0.0 in molecule inputs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[carlbuchmann]

LGTM

reviews comments have been addressed