Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs,eos_cli_config_gen)!: Change default encapsulation to path-selection for WAN iBGP EVPN peerings #4496

Merged
merged 30 commits into from
Sep 25, 2024
Merged

Feat(eos_designs,eos_cli_config_gen)!: Change default encapsulation to path-selection for WAN iBGP EVPN peerings #4496

merged 30 commits into from
Sep 25, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Sep 19, 2024

Change Summary

cf title

Component(s) name

arista.avd.eos_designs
arista.avd.eos_cli_config_gen

Proposed changes

  • Add support for gateway vxlan in router adaptive virtual topology (eos_cli_config_gen)
  • Add support for encapsulation path-seleciton for default, neighbors and peer-groups for bgp address_familiy_evpn (eos_cli_config_gen)
  • Add wan_encapsulation key to manipulate WAN iBGP EVPN peering encap (eos_designs)
  • porting-guide to revert to vxlan
  • update how-to guide

How to test

molecule tests for all

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc added this to the v5.0.0 milestone Sep 19, 2024
@gmuloc gmuloc requested review from a team as code owners September 19, 2024 15:52
@github-actions GitHub Actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4496
# Activate the virtual environment
source test-avd-pr-4496/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@make-dps-default-encap-mode-for-wan#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,make-dps-default-encap-mode-for-wan --force
# Optional: Install AVD examples
cd test-avd-pr-4496
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Sep 19, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs,eos_cli_config_gen): Change default encapsulation to path-selection for WAN iBGP EVPN peerings Feat(eos_designs,eos_cli_config_gen)!: Change default encapsulation to path-selection for WAN iBGP EVPN peerings Sep 20, 2024
ClausHolbechArista
ClausHolbechArista reviewed Sep 20, 2024
View reviewed changes
ansible_collections/arista/avd/docs/porting-guides/5.x.x.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/docs/porting-guides/5.x.x.md Show resolved Hide resolved
...-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-adaptive-virtual-topology.j2 Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-bgp.j2 Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/wan_encapsulation.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/overlay/router_bgp.py Outdated Show resolved Hide resolved
gmuloc and others added 6 commits September 20, 2024 09:38
@gmuloc @ClausHolbechArista
Update ansible_collections/arista/avd/docs/porting-guides/5.x.x.md
c481fd4 
Co-authored-by: Claus Holbech <[email protected]>
@gmuloc @ClausHolbechArista
Update python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation…
406e2a7 
…/router-adaptive-virtual-topology.j2

Co-authored-by: Claus Holbech <[email protected]>
@gmuloc @ClausHolbechArista
Update python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/r…
83504d2 
…outer_bgp.schema.yml

Co-authored-by: Claus Holbech <[email protected]>
@gmuloc @ClausHolbechArista
Update python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/r…
f00f671 
…outer_bgp.schema.yml

Co-authored-by: Claus Holbech <[email protected]>
@gmuloc @ClausHolbechArista
Update python-avd/pyavd/_eos_designs/schema/schema_fragments/wan_enca…
1d4bb3a 
…psulation.schema.yml

Co-authored-by: Claus Holbech <[email protected]>
@gmuloc @ClausHolbechArista
Update python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/r…
56204cc 
…outer_bgp.schema.yml

Co-authored-by: Claus Holbech <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gmuloc gmuloc marked this pull request as draft September 20, 2024 08:31
@gmuloc gmuloc marked this pull request as ready for review September 23, 2024 07:51
@gmuloc gmuloc requested a review from a team September 23, 2024 07:51
@gmuloc gmuloc requested review from ClausHolbechArista and a team September 24, 2024 12:54
@marcusmcpeek
Copy link
Contributor

LGTM - I have reviewed this PR, and the change to encapsulation path-selection works, and the variable to change back to encapsulation vxlan also works.

ClausHolbechArista
ClausHolbechArista approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions, but otherwise LGTM!

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-adaptive-virtual-topology.j2 Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/wan_encapsulation.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/overlay/router_bgp.py Show resolved Hide resolved
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Sep 25, 2024
gmuloc and others added 2 commits September 25, 2024 11:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista merged commit ad454eb into aristanetworks:devel Sep 25, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs|eos_cli_config_gen)! role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gmuloc @marcusmcpeek @ClausHolbechArista @carlbuchmann