Feat(eos_cli_config_gen): Global logging keys for congestion-drops, link-status, and repeat-messages

[nathanmusser]

Change Summary

Added new logging keys to disable repeat-messages, change the logging interval for the congestion-drops event, and set the global command for the link-status logging event.

Related Issue(s)

N/A

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added the following data model:

logging:
  repeat_messages: <bool>
  event:
    congestion_drops:
      interval: <int>
    link_status:
      global: <bool>

And added the associated j2 templates to render the associated commands:

no logging repeat-messages
logging event congestion-drops interval 600
logging event link-status global

How to test

Used the example dual-dc-l3ls topology and added the various commands to the FABRIC.yml group_var. Tested removing them and adding them and setting invalid values to make sure behavior is as expected. Commands are only rendered when the new model is present, etc..

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

Note: I'm still new to contributing here, but for the repo checklist item referring to documentation. My understanding is that for these simple knobs the documentation is generated from the schema. AFAIK there's nowhere else I need to add documentation? Should I be checking this box in those cases? Or leaving it unchecked since there is no documentation beyond what is auto-generated that needs to be modified?

Also I know I didn't open an issue for this first. It felt like a simple enough PR that there wouldn't be enough discussion to warrant an issue. Feel free to correct that assumption and I can create one as well as do so going forward for all PRs.

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4493
# Activate the virtual environment
source test-avd-pr-4493/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/nathanmusser/avd.git@logging_dev#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/nathanmusser/avd.git#/ansible_collections/arista/avd/,logging_dev --force
# Optional: Install AVD examples
cd test-avd-pr-4493
ansible-playbook arista.avd.install_examples

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Shivani-gslab]

LGTM!