-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs)!: Only render IGMP snooping querier version and address when enabled #4478
Refactor(eos_designs)!: Only render IGMP snooping querier version and address when enabled #4478
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4478
# Activate the virtual environment
source test-avd-pr-4478/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@internal-164#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,internal-164 --force
# Optional: Install AVD examples
cd test-avd-pr-4478
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a breaking change, so please check if we need to add this in porting-guide and release notes.
Everything else looks good to me!
c861984
to
2bfbe97
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Render ip igmp snooping for version and address only when igmp snooping querier is enabled.
Related Issue(s)
Fixes https://github.com/aristanetworks/avd-internal/issues/164
Component(s) name
arista.avd.eos_designs
Proposed changes
Render ip igmp snooping for version and address only when igmp snooping querier is enabled.
How to test
Run molecule
Checklist
User Checklist
Repository Checklist