Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs)!: Only render IGMP snooping querier version and address when enabled #4478

Merged
merged 9 commits into from
Sep 20, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Render ip igmp snooping for version and address only when igmp snooping querier is enabled.

Related Issue(s)

Fixes https://github.com/aristanetworks/avd-internal/issues/164

Component(s) name

arista.avd.eos_designs

Proposed changes

Render ip igmp snooping for version and address only when igmp snooping querier is enabled.

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Sep 17, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4478
# Activate the virtual environment
source test-avd-pr-4478/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@internal-164#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,internal-164 --force
# Optional: Install AVD examples
cd test-avd-pr-4478
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Sep 17, 2024
@MaheshGSLAB MaheshGSLAB changed the title Refactor(eos_designs)!: Render ip igmp snooping for version and address only when igmp snooping querier is enabled Refactor(eos_designs)!: Render ip igmp snooping for version and address only, when igmp snooping querier is enabled Sep 17, 2024
@MaheshGSLAB MaheshGSLAB changed the title Refactor(eos_designs)!: Render ip igmp snooping for version and address only, when igmp snooping querier is enabled Refactor(eos_designs)!: Render ip igmp snooping for version and address, only when igmp snooping querier is enabled Sep 17, 2024
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a breaking change, so please check if we need to add this in porting-guide and release notes.
Everything else looks good to me!

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Sep 18, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review September 18, 2024 10:55
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners September 18, 2024 10:55
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_designs)!: Render ip igmp snooping for version and address, only when igmp snooping querier is enabled Refactor(eos_designs)!: Render ip igmp snooping querier version and address, only when igmp snooping querier is enabled Sep 18, 2024
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_designs)!: Render ip igmp snooping querier version and address, only when igmp snooping querier is enabled Refactor(eos_designs)!: Only render IGMP snooping querier version and address when enabled Sep 18, 2024
@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Sep 18, 2024
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 7be32b9 into aristanetworks:devel Sep 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Refactor(eos_designs)! state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants