Refactor(eos_designs)!: Change default descriptions for connected endpoints and network ports

[ClausHolbechArista]

Change Summary

Change default descriptions for connected endpoints and network ports

Component(s) name

arista.avd.eos_designs

Proposed changes

• Adding new consistent default descriptions for connected endpoints where the type is added first in upper case. Like SERVER_<server_name>_<server_port>
• Add templating support for the description key under connected endpoints and network ports
• Add templating support for the descriptions[] key under connected endpoints
• Add keys with default templates:
  • default_connected_endpoints_description
  • default_connected_endpoints_port_channel_description
  • default_network_ports_description
  • default_network_ports__port_channel_description
• Add endpoint key to network_ports
• Add endpoint_port_channel under port_channel for both network_ports and connected endpoints.
• Updated porting guide

How to test

• Update molecule scenarios and examples
• Verified that custom description logic still works in unit tests for templates and python module
• Verified that custom description logic still works in evpn_underlay_ebgp_overlay_ebgp for python module

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4457
# Activate the virtual environment
source test-avd-pr-4457/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/connected-endpoints-descriptions#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/connected-endpoints-descriptions --force
# Optional: Install AVD examples
cd test-avd-pr-4457
ansible-playbook arista.avd.install_examples

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[gmuloc]

quick comments - will review the rest afterwards

[gmuloc]

For network ports the fact that we use endpoints instead of description make some change for the peer key and hence the fabric doc that could have an impact on users relying upon it in AVD 4.x though I think the change makes sense.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[gmuloc]

LGTM once conflicts are resolved (by regenerating the files)

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[carlbuchmann]

LGTM, please review updates to documentation before merging

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud