Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Add CV Pathfinder AVD example #4453

Merged
merged 59 commits into from
Oct 24, 2024
Merged

Doc: Add CV Pathfinder AVD example #4453

merged 59 commits into from
Oct 24, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Sep 10, 2024 •
edited by JulioPDX
Loading

Change Summary

This PR adds an example on how to deploy Arista CV Pathfinder solution

Component(s) name

documentation

Proposed changes

Add an example

How to test

Require CloudEOS lab with the topology and a CVaaS tenant.

Checklist

User Checklist - @JulioPDX

  • Address TODOs in README
  • Check on live topology
  • Rename devices to sitex-
  • Update diagrams to sitex-
  • Improve image layout and quality
  • Add DHCP on the WAN interface for sites leveraging inet-cloud
  • Add eBGP for site 2 (wan2)
  • Improve the README with details and information
  • Run through the lab
  • Improve WAN how-to guide if required
  • Add note on policies not configured if link does not exist (MPLS)
  • Add diagram to explain AVT/policies
  • Add constraint example around policies
  • Add licensing required note
  • Remove inline jinja for MGMT IPs

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions GitHub Actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4453
# Activate the virtual environment
source test-avd-pr-4453/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@wan-example#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,wan-example --force
# Optional: Install AVD examples
cd test-avd-pr-4453
ansible-playbook arista.avd.install_examples

ClausHolbechArista
ClausHolbechArista reviewed Sep 10, 2024
View reviewed changes
ansible_collections/arista/avd/examples/cv-pathfinder/deploy.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/all.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/all.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/TRANSPORTS.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/TRANSPORTS.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/WAN/vault.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/all.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/WAN/management.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/WAN/management.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/PATHFINDERS.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added type: code quality CI and development toolset state: CI Updated CI scenario have been updated in the PR labels Sep 10, 2024
@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Sep 11, 2024
ClausHolbechArista
ClausHolbechArista reviewed Sep 12, 2024
View reviewed changes
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/WAN/management.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/WAN/management.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/WAN/management.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/WAN/management.yml Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/WAN/management.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/host_vars/cloudvision/vault.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/host_vars/inet-cloud.yml Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/ansible.cfg Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/deploy.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/inventory.yml Outdated Show resolved Hide resolved
@JulioPDX JulioPDX force-pushed the wan-example branch 2 times, most recently from 66ada63 to 7e8898e Compare September 19, 2024 23:40
@JulioPDX JulioPDX force-pushed the wan-example branch 3 times, most recently from cf67cce to dcb4dce Compare October 7, 2024 19:19
gmuloc and others added 13 commits October 8, 2024 10:36
@gmuloc @JulioPDX
Doc: Add CV Pathfinder AVD example
69962cb
@gmuloc @ClausHolbechArista @JulioPDX
Update ansible_collections/arista/avd/examples/cv-pathfinder/deploy.yml
8a0a0ca 
Co-authored-by: Claus Holbech <[email protected]>
@gmuloc @ClausHolbechArista @JulioPDX
Update ansible_collections/arista/avd/examples/cv-pathfinder/group_va…
0554bc2 
…rs/WAN/cv_pathfinder_settings.yml

Co-authored-by: Claus Holbech <[email protected]>
@gmuloc @ClausHolbechArista @JulioPDX
Update ansible_collections/arista/avd/examples/cv-pathfinder/group_va…
5006955 
…rs/all.yml

Co-authored-by: Claus Holbech <[email protected]>
@gmuloc @JulioPDX
Doc: Address PR comments
b326f33
@gmuloc @JulioPDX
ci: Add to molecule
95494bc
@gmuloc @JulioPDX
doc: Address PR comment
cd9db61
@gmuloc @JulioPDX
Doc: Add STUN DTLS and edit README
0f9debd
@gmuloc @JulioPDX
Doc: Add more info
0c6dd86
@gmuloc @JulioPDX
chore: Cleaning up my mess
2cc360f
@gmuloc @ClausHolbechArista @JulioPDX
Update ansible_collections/arista/avd/examples/cv-pathfinder/group_va…
be89ced 
…rs/WAN/management.yml

Co-authored-by: Claus Holbech <[email protected]>
@gmuloc @ClausHolbechArista @JulioPDX
Update ansible_collections/arista/avd/examples/cv-pathfinder/group_va…
59b7ff3 
…rs/WAN/management.yml

Co-authored-by: Claus Holbech <[email protected]>
@gmuloc @ClausHolbechArista @JulioPDX
Update ansible_collections/arista/avd/examples/cv-pathfinder/group_va…
1415522 
…rs/WAN/management.yml

Co-authored-by: Claus Holbech <[email protected]>
gmuloc
gmuloc commented Oct 16, 2024
View reviewed changes
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/SITE1.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/SITE1.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/SITE2.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/SITE1.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/SITE2.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/WAN/management.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/WAN/management.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/inventory.yml Outdated Show resolved Hide resolved
...ta/avd/examples/cv-pathfinder/switch-basic-configurations/inet-cloud-basic-configuration.txt Show resolved Hide resolved
.../eos_config_deploy_cvp/intended/structured_configs/cvp-empty-filter/cv_server_configlets.yml Outdated Show resolved Hide resolved
gmuloc and others added 13 commits October 16, 2024 12:02
gmuloc
gmuloc commented Oct 24, 2024
View reviewed changes
Copy link
Contributor Author

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - ran some basic failover tests in our lab.
Reviewed the README and updated with info

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ClausHolbechArista
ClausHolbechArista approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 3cac535 into aristanetworks:devel Oct 24, 2024
48 checks passed
pvinci-arista pushed a commit to pvinci-arista/ansible-avd that referenced this pull request Oct 25, 2024
@gmuloc @JulioPDX @pvinci-arista
Doc: Add CV Pathfinder AVD example (aristanetworks#4453)
be93974 
Co-authored-by: JulioPDX <[email protected]>
gmuloc added a commit to gmuloc/avd that referenced this pull request Oct 29, 2024
@gmuloc @JulioPDX
Doc: Add CV Pathfinder AVD example (aristanetworks#4453)
76a9c1f 
Co-authored-by: JulioPDX <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulioPDX JulioPDX JulioPDX left review comments

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@gmuloc gmuloc

@JulioPDX JulioPDX

Labels
rn: Doc state: CI Updated CI scenario have been updated in the PR type: code quality CI and development toolset
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gmuloc @JulioPDX @ClausHolbechArista