Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: cv_deploy molecule test to use new infra #4441

Merged
merged 13 commits into from
Oct 10, 2024

Conversation

sugetha24
Copy link
Contributor

Change Summary

Updated molecule tests to use the new EVE-NG lab

Copy link

github-actions bot commented Sep 6, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4441
# Activate the virtual environment
source test-avd-pr-4441/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/sugetha24/ansible-avd.git@cv_deploy-molecule-update#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/sugetha24/ansible-avd.git#/ansible_collections/arista/avd/,cv_deploy-molecule-update --force
# Optional: Install AVD examples
cd test-avd-pr-4441
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Sep 6, 2024
@sugetha24 sugetha24 marked this pull request as ready for review September 10, 2024 18:12
@sugetha24 sugetha24 requested review from a team as code owners September 10, 2024 18:12
@sugetha24 sugetha24 force-pushed the cv_deploy-molecule-update branch from 2994e4b to 7c58a6f Compare September 12, 2024 22:09
@sugetha24 sugetha24 force-pushed the cv_deploy-molecule-update branch 2 times, most recently from aa4bc59 to 3be537b Compare September 20, 2024 13:29
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested that it runs but the PR LGTM

@sugetha24
Copy link
Contributor Author

Have not tested that it runs but the PR LGTM

Please test the PR when you get a chance

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Sep 23, 2024
@sugetha24 sugetha24 force-pushed the cv_deploy-molecule-update branch from f8aa3a7 to e19bc32 Compare September 27, 2024 19:00
@sugetha24
Copy link
Contributor Author

sugetha24 commented Oct 1, 2024

@gmuloc and @alexeygorbunov
I have separated the tests into different playbooks and made some changes so we don't have to stop and start streaming. Please re test again

@sugetha24 sugetha24 force-pushed the cv_deploy-molecule-update branch from 14fc834 to 016d1c6 Compare October 1, 2024 16:58
@sugetha24 sugetha24 force-pushed the cv_deploy-molecule-update branch 3 times, most recently from 1da3eec to 7ba1513 Compare October 7, 2024 22:50
@sugetha24 sugetha24 force-pushed the cv_deploy-molecule-update branch from dc939fd to f556e9e Compare October 9, 2024 20:32
@sugetha24
Copy link
Contributor Author

Recent changes LGTM

Copy link
Contributor

@alexeygorbunov alexeygorbunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - at some point we should try to make the workspace/cc names meaningful in CV if we can but thats a great improvement already

@gmuloc gmuloc merged commit 184f1a7 into aristanetworks:devel Oct 10, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: CI state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants