-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Set ssh authentication protocols and empty password #4436
Conversation
…(protocol and empty-passwords)
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4436
# Activate the virtual environment
source test-avd-pr-4436/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/jmussmann/avd.git@issue/4435#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/jmussmann/avd.git#/ansible_collections/arista/avd/,issue/4435 --force
# Optional: Install AVD examples
cd test-avd-pr-4436
ansible-playbook arista.avd.install_examples |
In this PR the "multi-factor" option is missing. I did not find much in the documentation about it "https://www.arista.com/en/um-eos/eos-session-management-command". While testing i figured out, that it can be set multiple times. If anyone has more information I can add this feature as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice contribution. Thank you! I have given some hints for improvements using some of our filters and some feedback on the data model.
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/management-ssh.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/management-ssh.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/management-ssh.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/management-ssh.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/management-ssh.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/management_ssh.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/management_ssh.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/management_ssh.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/management-ssh.j2
Outdated
Show resolved
Hide resolved
…(protocol and empty-passwords) - changes after review
@ClausHolbechArista Thank you very much for your feedback. I added the suggested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. No need to implement the multi factor at this time. There will be a TOI for it very soon.
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/management-ssh.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/management-ssh.j2
Outdated
Show resolved
Hide resolved
…(protocol and empty-passwords) - changes after review
@ClausHolbechArista Thanks. Sorry didn't see that. It is changed now. |
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/management_ssh.schema.yml
Outdated
Show resolved
Hide resolved
…(protocol and empty-passwords) - changes after review - remove default for empty_passwords
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
This PR adds a new key with two sub keys to management_ssh.
Related Issue(s)
Fixes #4435
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Run eos_cli_config_gen molecule tests:
Test added to: "management-ssh" host.
Checklist
User Checklist
Repository Checklist