Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Set ssh authentication protocols and empty password #4436

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

jmussmann
Copy link
Contributor

Change Summary

This PR adds a new key with two sub keys to management_ssh.

authentication:
    empty_passwords:
    protocol:

Related Issue(s)

Fixes #4435

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • add the new keys to the "management_ssh.schema.yml" schema file
  • use these in the "eos/management-ssh.j2" and "documentation/management-ssh.j2" templates
  • add options to molecule tests

How to test

Run eos_cli_config_gen molecule tests:

python -m molecule converge -s eos_cli_config_gen

Test added to: "management-ssh" host.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@jmussmann jmussmann requested review from a team as code owners September 6, 2024 11:35
Copy link

github-actions bot commented Sep 6, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4436
# Activate the virtual environment
source test-avd-pr-4436/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/jmussmann/avd.git@issue/4435#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/jmussmann/avd.git#/ansible_collections/arista/avd/,issue/4435 --force
# Optional: Install AVD examples
cd test-avd-pr-4436
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Sep 6, 2024
@jmussmann
Copy link
Contributor Author

In this PR the "multi-factor" option is missing. I did not find much in the documentation about it "https://www.arista.com/en/um-eos/eos-session-management-command".

While testing i figured out, that it can be set multiple times. If anyone has more information I can add this feature as well.

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice contribution. Thank you! I have given some hints for improvements using some of our filters and some feedback on the data model.

…(protocol and empty-passwords) - changes after review
@jmussmann
Copy link
Contributor Author

@ClausHolbechArista Thank you very much for your feedback. I added the suggested changes.

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. No need to implement the multi factor at this time. There will be a TOI for it very soon.

…(protocol and empty-passwords) - changes after review
@jmussmann
Copy link
Contributor Author

@ClausHolbechArista Thanks. Sorry didn't see that. It is changed now.

@MaheshGSLAB MaheshGSLAB requested a review from a team September 6, 2024 12:54
…(protocol and empty-passwords) - changes after review - remove default for empty_passwords
Copy link

sonarqubecloud bot commented Sep 6, 2024

Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 4e310f9 into aristanetworks:devel Sep 6, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Set ssh authentication protocols and empty password
4 participants