Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs)!: Shutdown interfaces and bgp towards undeployed peers by default #4424

Merged

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Sep 3, 2024

Change Summary

Flip default of shutdown_bgp_towards_undeployed_peers & shutdown_interfaces_towards_undeployed_peers

Related Issue(s)

Fixes #159

Component(s) name

arista.avd.eos_designs

Proposed changes

Flip default of shutdown_bgp_towards_undeployed_peers & shutdown_interfaces_towards_undeployed_peers

How to test

Molecule tests

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4424
# Activate the virtual environment
source test-avd-pr-4424/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@flip_default_159#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,flip_default_159 --force
# Optional: Install AVD examples
cd test-avd-pr-4424
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Sep 3, 2024
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_designs): Flip default of shutdown_bgp_towards_undeployed_peers & shutdown_interfaces_towards_undeployed_peers Feat(eos_designs)!: Shutdown interfaces and bgp towards undeployed peers by default Sep 4, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review September 4, 2024 05:45
@Shivani-gslab Shivani-gslab requested review from a team as code owners September 4, 2024 05:45
@laxmikantchintakindi
Copy link
Contributor

We need a test where these keys are set to false.

@Shivani-gslab Shivani-gslab marked this pull request as draft September 4, 2024 13:56
@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Sep 5, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review September 5, 2024 07:49
Copy link

sonarqubecloud bot commented Sep 5, 2024

@ClausHolbechArista ClausHolbechArista merged commit cf03230 into aristanetworks:devel Sep 5, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs)! role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants