-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs)!: Shutdown interfaces and bgp towards undeployed peers by default #4424
Merged
ClausHolbechArista
merged 5 commits into
aristanetworks:devel
from
Shivani-gslab:flip_default_159
Sep 5, 2024
Merged
Feat(eos_designs)!: Shutdown interfaces and bgp towards undeployed peers by default #4424
ClausHolbechArista
merged 5 commits into
aristanetworks:devel
from
Shivani-gslab:flip_default_159
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Sep 3, 2024
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4424
# Activate the virtual environment
source test-avd-pr-4424/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@flip_default_159#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,flip_default_159 --force
# Optional: Install AVD examples
cd test-avd-pr-4424
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
type: documentation
Improvements or additions to documentation
label
Sep 3, 2024
ClausHolbechArista
changed the title
Refactor(eos_designs): Flip default of shutdown_bgp_towards_undeployed_peers & shutdown_interfaces_towards_undeployed_peers
Feat(eos_designs)!: Shutdown interfaces and bgp towards undeployed peers by default
Sep 4, 2024
We need a test where these keys are set to false. |
MaheshGSLAB
approved these changes
Sep 5, 2024
…rfaces_towards_undeployed_peers
Co-authored-by: laxmikantchintakindi <[email protected]>
Co-authored-by: Claus Holbech <[email protected]>
Shivani-gslab
force-pushed
the
flip_default_159
branch
from
September 5, 2024 12:23
75fa90b
to
13e4431
Compare
Quality Gate passedIssues Measures |
ClausHolbechArista
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Feat(eos_designs)!
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
type: documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Flip default of shutdown_bgp_towards_undeployed_peers & shutdown_interfaces_towards_undeployed_peers
Related Issue(s)
Fixes #159
Component(s) name
arista.avd.eos_designs
Proposed changes
Flip default of shutdown_bgp_towards_undeployed_peers & shutdown_interfaces_towards_undeployed_peers
How to test
Molecule tests
Checklist
Repository Checklist