Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for IPv4 BGP Labeled-Unicast (BGP-LU) #4412

Merged
merged 38 commits into from
Sep 27, 2024
Merged

Feat(eos_cli_config_gen): Add support for IPv4 BGP Labeled-Unicast (BGP-LU) #4412

merged 38 commits into from
Sep 27, 2024

Conversation

colinmacgiolla
Copy link
Contributor

Change Summary

This PR is based on the other IPv4 Address-Families and adds support for BGP-LU

Related Issue(s)

Fixes #4380

Component(s) name

arista.avd.python-avd

Proposed changes

Many - the datamodel is based on pre-existing ones. All changes live under router_bgp.address_family_ipv4_labeled_unicast

How to test

molecule tests added

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@colinmacgiolla
Create initial schema
31814d3
@colinmacgiolla
Cleanup
6c25fb1
@colinmacgiolla
Schema updates
afa21dd 
Initial CLI render - peer-groups not done yet
Documentation not done yet
Molecule tests not done
@colinmacgiolla
Fix template
ec57854 
Add inital testing
@colinmacgiolla
Enhanced testing
903c6c3
@colinmacgiolla
update molecule outputs
6511f26
@colinmacgiolla
Generate documentation
599fb7c
@colinmacgiolla
Add handling for peer-groups
e5d8044
@colinmacgiolla
doc update
e00a61a
@colinmacgiolla
Peer groups enabled
f75a17b 
Added tests
Updated generated markdown
@github-actions GitHub Actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4412
# Activate the virtual environment
source test-avd-pr-4412/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/colinmacgiolla/ansible-avd.git@bgp-labeled-unicast#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/colinmacgiolla/ansible-avd.git#/ansible_collections/arista/avd/,bgp-labeled-unicast --force
# Optional: Install AVD examples
cd test-avd-pr-4412
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Aug 29, 2024
@colinmacgiolla colinmacgiolla changed the title Feat(eos_config_cli_gen): Add support for IPv4 BGP Labeled-Unicast (BGP-LU) Feat(eos_cli_config_gen): Add support for IPv4 BGP Labeled-Unicast (BGP-LU) Aug 29, 2024
@colinmacgiolla colinmacgiolla marked this pull request as ready for review August 29, 2024 14:05
@colinmacgiolla colinmacgiolla requested review from a team as code owners August 29, 2024 14:05
gmuloc
gmuloc reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tried on a device so just a couple of early comments

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-bgp.j2 Outdated Show resolved Hide resolved
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review September 19, 2024 12:16
@ClausHolbechArista ClausHolbechArista removed the one approval This PR has one approval and is only missing one more. label Sep 23, 2024
@ClausHolbechArista
Copy link
Contributor

converting to draft since we need to confirm some data model choices. Thanks!

@ClausHolbechArista ClausHolbechArista marked this pull request as draft September 27, 2024 06:56
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review September 27, 2024 09:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista merged commit abfe124 into aristanetworks:devel Sep 27, 2024
43 checks passed
@colinmacgiolla colinmacgiolla deleted the bgp-labeled-unicast branch October 18, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laxmikantchintakindi laxmikantchintakindi laxmikantchintakindi left review comments

@gmuloc gmuloc gmuloc left review comments

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@colinmacgiolla colinmacgiolla

@laxmikantchintakindi laxmikantchintakindi

Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat (eos_cli_config_gen): Add support for BGP labeled-unicast
5 participants
@colinmacgiolla @ClausHolbechArista @gmuloc @MaheshGSLAB @laxmikantchintakindi