Fix(eos_designs)!: Do not render EVPN address-family on MPLS devices unless overlay_address_families includes evpn

[ClausHolbechArista]

Change Summary

Do not render EVPN address-family on MPLS devices unless overlay_address_families includes evpn

Related Issue(s)

Fixes #4176

Component(s) name

arista.avd.eos_designs

Proposed changes

Check if overlay is EVPN + MPLS before configuring EVPN address family on MPLS nodes.

How to test

Existing example exposed the issue on both RR and PE.

Tested manually by adding overlay_address_families: [evpn, vpn-ipv4] on the RR and it added back the EVPN address family.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4390
# Activate the virtual environment
source test-avd-pr-4390/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix(eos_designs)--Fix-BGP-address-families-for-MPLS-RR#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix(eos_designs)--Fix-BGP-address-families-for-MPLS-RR --force
# Optional: Install AVD examples
cd test-avd-pr-4390
ansible-playbook arista.avd.install_examples

[dgonzalez85]

Tested and all good now we do not render in RRs and the PEs the EVPN address family

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud