Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Enhance encapsulation schema/template for ethernet and port-channel interfaces #4388

Merged

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Aug 23, 2024

Change Summary

Modifying vlan_id and encapsulation schema/template for ethernet and port-channel interfaces

Related Issue(s)

Fixes #4337

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • Adding schema for vlan_id and encapsulation settings in ethernet-interfaces and port-channel interfaces.
  • Deprecating old keys which were dependent on type key to render the config.
  • Updating EOS and documentation templates for these settings.
  • Adding test-cases for new and deprecated keys.
  • Fixing the bugs on existing template for deprecated keys.
  • Updated porting-guide and release notes for AVD5.x.x

How to test

Test with EOS CLI and molecule tests.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Aug 23, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4388
# Activate the virtual environment
source test-avd-pr-4388/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@interface_encapsulation#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,interface_encapsulation --force
# Optional: Install AVD examples
cd test-avd-pr-4388
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: conflict PR with conflict label Aug 23, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Shivani-gslab Shivani-gslab force-pushed the interface_encapsulation branch from 820cd0a to f410758 Compare August 26, 2024 11:25
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 26, 2024
@Shivani-gslab Shivani-gslab force-pushed the interface_encapsulation branch 4 times, most recently from 2c7eb55 to fcc1ae5 Compare August 27, 2024 05:37
@Shivani-gslab Shivani-gslab changed the title Feat(eos_cli_config_gen): Modifying encapsulation schema/template for ethernet and port-channel interfaces Feat(eos_cli_config_gen): Modifying vlan_id and encapsulation schema/template for ethernet and port-channel interfaces Aug 27, 2024
@Shivani-gslab Shivani-gslab force-pushed the interface_encapsulation branch 4 times, most recently from c9f71fd to da01755 Compare August 27, 2024 12:19
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Aug 27, 2024
@Shivani-gslab Shivani-gslab force-pushed the interface_encapsulation branch 3 times, most recently from 71bdc33 to 9697c26 Compare August 28, 2024 04:57
@Shivani-gslab Shivani-gslab marked this pull request as ready for review August 28, 2024 09:18
@Shivani-gslab Shivani-gslab requested review from a team as code owners August 28, 2024 09:18
@Shivani-gslab Shivani-gslab force-pushed the interface_encapsulation branch from 9697c26 to 5c53c86 Compare August 28, 2024 12:54
@Vibhu-gslab Vibhu-gslab force-pushed the interface_encapsulation branch from b7c656a to 4af1853 Compare September 3, 2024 13:00
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): Modifying vlan_id and encapsulation schema/template for ethernet and port-channel interfaces Feat(eos_cli_config_gen): Enhance encapsulation schema/template for ethernet and port-channel interfaces Sep 4, 2024
@Shivani-gslab Shivani-gslab force-pushed the interface_encapsulation branch from 93b75d5 to f7f0bf0 Compare September 4, 2024 08:11
@Shivani-gslab Shivani-gslab force-pushed the interface_encapsulation branch from 4f07555 to c657e72 Compare September 4, 2024 08:14
@Shivani-gslab Shivani-gslab force-pushed the interface_encapsulation branch 3 times, most recently from 4a7af28 to e9f4f59 Compare September 4, 2024 13:15
@Shivani-gslab Shivani-gslab marked this pull request as draft September 4, 2024 13:20
@Shivani-gslab Shivani-gslab force-pushed the interface_encapsulation branch from e9f4f59 to df19576 Compare September 4, 2024 13:22
Copy link

sonarqubecloud bot commented Sep 4, 2024

@Shivani-gslab Shivani-gslab marked this pull request as ready for review September 4, 2024 13:26
@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Sep 5, 2024
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the big one!

@ClausHolbechArista ClausHolbechArista merged commit 801eb66 into aristanetworks:devel Sep 5, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Add encapsulation data-model to interfaces schema and config.
5 participants