-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Enhance encapsulation schema/template for ethernet and port-channel interfaces #4388
Feat(eos_cli_config_gen): Enhance encapsulation schema/template for ethernet and port-channel interfaces #4388
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4388
# Activate the virtual environment
source test-avd-pr-4388/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@interface_encapsulation#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,interface_encapsulation --force
# Optional: Install AVD examples
cd test-avd-pr-4388
ansible-playbook arista.avd.install_examples |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
...lections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/ethernet-interfaces.md
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
820cd0a
to
f410758
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
2c7eb55
to
fcc1ae5
Compare
c9f71fd
to
da01755
Compare
71bdc33
to
9697c26
Compare
9697c26
to
5c53c86
Compare
b7c656a
to
4af1853
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
93b75d5
to
f7f0bf0
Compare
4f07555
to
c657e72
Compare
4a7af28
to
e9f4f59
Compare
e9f4f59
to
df19576
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the big one!
Change Summary
Modifying vlan_id and encapsulation schema/template for ethernet and port-channel interfaces
Related Issue(s)
Fixes #4337
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
type
key to render the config.How to test
Test with EOS CLI and molecule tests.
Checklist
Repository Checklist