Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs)!: Change the default value of isis_system_id_format to underlay_loopback #4373

Merged
merged 14 commits into from
Aug 27, 2024
Merged

Refactor(eos_designs)!: Change the default value of isis_system_id_format to underlay_loopback #4373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
881174a
Refactor(eos_designs): Flip default to
Aug 19, 2024
7c961e3
Update porting guide.
Aug 19, 2024
ac99b9e
Update key description.
Aug 19, 2024
a8460da
Fix doc.
Aug 19, 2024
8836af4
Execute TODO in router_isis.py.
Aug 19, 2024
429b1ed
Update ansible_collections/arista/avd/docs/porting-guides/5.x.x.md
laxmikantchintakindi Aug 20, 2024
24e9395
Fix porting guide.
Aug 20, 2024
aa47a55
Adding negative unit tests for missing variable.
Aug 20, 2024
456bbea
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 23, 2024
80eb2a0
Reword the error msg.
Aug 26, 2024
9008556
Fix CI.
Aug 26, 2024
822adf1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 26, 2024
9699c2c
Merge branch 'devel' into todo/flip_default_to_underlay_loopback
ClausHolbechArista Aug 27, 2024
6f66ac4
Merge branch 'devel' into todo/flip_default_to_underlay_loopback
gmuloc Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ansible_collections/arista/avd/docs/porting-guides/5.x.x.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,17 @@ By default an MLAG ID will only be configured on Port-Channel downlinks dual-hom
+ mlag_on_orphan_port_channel_downlink: true
```

### Default value of `isis_system_id_format` is changed to `underlay_loopback`

In AVD 4.0.0, `node_id` was the default value of `isis_system_id_format`.
In AVD 5.0.0, this default value is changed to `underlay_loopback`.

laxmikantchintakindi marked this conversation as resolved.
Show resolved Hide resolved
To retain the previous behavior set the value back to `node_id`:

```diff
+isis_system_id_format: node_id
```

## Changes to role `arista.avd.eos_cli_config_gen`

TODO: Level 3 sections for each change with details on how to migrate
Expand Down
4 changes: 2 additions & 2 deletions ansible_collections/arista/avd/examples/isis-ldp-ipvpn/documentation/devices/p1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
| Settings | Value |
| -------- | ----- |
| Instance | CORE |
| Net-ID | 49.0001.0000.0000.0001.00 |
| Net-ID | 49.0001.0102.5500.0001.00 |
| Type | level-2 |
| Router-ID | 10.255.0.1 |
| Log Adjacency Changes | True |
Expand Down Expand Up @@ -381,7 +381,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
```eos
!
router isis CORE
net 49.0001.0000.0000.0001.00
net 49.0001.0102.5500.0001.00
is-type level-2
router-id ipv4 10.255.0.1
log-adjacency-changes
Expand Down
4 changes: 2 additions & 2 deletions ansible_collections/arista/avd/examples/isis-ldp-ipvpn/documentation/devices/p2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
| Settings | Value |
| -------- | ----- |
| Instance | CORE |
| Net-ID | 49.0001.0000.0000.0002.00 |
| Net-ID | 49.0001.0102.5500.0002.00 |
| Type | level-2 |
| Router-ID | 10.255.0.2 |
| Log Adjacency Changes | True |
Expand Down Expand Up @@ -381,7 +381,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
```eos
!
router isis CORE
net 49.0001.0000.0000.0002.00
net 49.0001.0102.5500.0002.00
is-type level-2
router-id ipv4 10.255.0.2
log-adjacency-changes
Expand Down
4 changes: 2 additions & 2 deletions ansible_collections/arista/avd/examples/isis-ldp-ipvpn/documentation/devices/p3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
| Settings | Value |
| -------- | ----- |
| Instance | CORE |
| Net-ID | 49.0001.0000.0000.0003.00 |
| Net-ID | 49.0001.0102.5500.0003.00 |
| Type | level-2 |
| Router-ID | 10.255.0.3 |
| Log Adjacency Changes | True |
Expand All @@ -361,7 +361,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
```eos
!
router isis CORE
net 49.0001.0000.0000.0003.00
net 49.0001.0102.5500.0003.00
is-type level-2
router-id ipv4 10.255.0.3
log-adjacency-changes
Expand Down
4 changes: 2 additions & 2 deletions ansible_collections/arista/avd/examples/isis-ldp-ipvpn/documentation/devices/p4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
| Settings | Value |
| -------- | ----- |
| Instance | CORE |
| Net-ID | 49.0001.0000.0000.0004.00 |
| Net-ID | 49.0001.0102.5500.0004.00 |
| Type | level-2 |
| Router-ID | 10.255.0.4 |
| Log Adjacency Changes | True |
Expand All @@ -361,7 +361,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
```eos
!
router isis CORE
net 49.0001.0000.0000.0004.00
net 49.0001.0102.5500.0004.00
is-type level-2
router-id ipv4 10.255.0.4
log-adjacency-changes
Expand Down
4 changes: 2 additions & 2 deletions ...ble_collections/arista/avd/examples/isis-ldp-ipvpn/documentation/devices/pe1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ router ospf 10 vrf C1_VRF1
| Settings | Value |
| -------- | ----- |
| Instance | CORE |
| Net-ID | 49.0001.0000.0001.0001.00 |
| Net-ID | 49.0001.0102.5500.1001.00 |
| Type | level-2 |
| Router-ID | 10.255.1.1 |
| Log Adjacency Changes | True |
Expand All @@ -426,7 +426,7 @@ router ospf 10 vrf C1_VRF1
```eos
!
router isis CORE
net 49.0001.0000.0001.0001.00
net 49.0001.0102.5500.1001.00
is-type level-2
router-id ipv4 10.255.1.1
log-adjacency-changes
Expand Down
4 changes: 2 additions & 2 deletions ...ble_collections/arista/avd/examples/isis-ldp-ipvpn/documentation/devices/pe2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ router ospf 10 vrf C1_VRF1
| Settings | Value |
| -------- | ----- |
| Instance | CORE |
| Net-ID | 49.0001.0000.0001.0002.00 |
| Net-ID | 49.0001.0102.5500.1002.00 |
| Type | level-2 |
| Router-ID | 10.255.1.2 |
| Log Adjacency Changes | True |
Expand All @@ -426,7 +426,7 @@ router ospf 10 vrf C1_VRF1
```eos
!
router isis CORE
net 49.0001.0000.0001.0002.00
net 49.0001.0102.5500.1002.00
is-type level-2
router-id ipv4 10.255.1.2
log-adjacency-changes
Expand Down
4 changes: 2 additions & 2 deletions ...ble_collections/arista/avd/examples/isis-ldp-ipvpn/documentation/devices/pe3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ router ospf 10 vrf C1_VRF1
| Settings | Value |
| -------- | ----- |
| Instance | CORE |
| Net-ID | 49.0001.0000.0001.0003.00 |
| Net-ID | 49.0001.0102.5500.1003.00 |
| Type | level-2 |
| Router-ID | 10.255.1.3 |
| Log Adjacency Changes | True |
Expand All @@ -415,7 +415,7 @@ router ospf 10 vrf C1_VRF1
```eos
!
router isis CORE
net 49.0001.0000.0001.0003.00
net 49.0001.0102.5500.1003.00
is-type level-2
router-id ipv4 10.255.1.3
log-adjacency-changes
Expand Down
4 changes: 2 additions & 2 deletions ...ble_collections/arista/avd/examples/isis-ldp-ipvpn/documentation/devices/rr1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
| Settings | Value |
| -------- | ----- |
| Instance | CORE |
| Net-ID | 49.0001.0000.0002.0001.00 |
| Net-ID | 49.0001.0102.5500.2001.00 |
| Type | level-2 |
| Router-ID | 10.255.2.1 |
| Log Adjacency Changes | True |
Expand All @@ -364,7 +364,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
```eos
!
router isis CORE
net 49.0001.0000.0002.0001.00
net 49.0001.0102.5500.2001.00
is-type level-2
router-id ipv4 10.255.2.1
log-adjacency-changes
Expand Down
4 changes: 2 additions & 2 deletions ...ble_collections/arista/avd/examples/isis-ldp-ipvpn/documentation/devices/rr2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
| Settings | Value |
| -------- | ----- |
| Instance | CORE |
| Net-ID | 49.0001.0000.0002.0002.00 |
| Net-ID | 49.0001.0102.5500.2002.00 |
| Type | level-2 |
| Router-ID | 10.255.2.2 |
| Log Adjacency Changes | True |
Expand All @@ -364,7 +364,7 @@ ip route vrf MGMT 0.0.0.0/0 172.16.1.1
```eos
!
router isis CORE
net 49.0001.0000.0002.0002.00
net 49.0001.0102.5500.2002.00
is-type level-2
router-id ipv4 10.255.2.2
log-adjacency-changes
Expand Down
18 changes: 9 additions & 9 deletions ...arista/avd/examples/isis-ldp-ipvpn/documentation/fabric/FABRIC-documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,15 @@

| POD | Node | CLNS Address |
| --- | ---- | ------------ |
| FABRIC | p1 | 49.0001.0000.0000.0001.00 |
| FABRIC | p2 | 49.0001.0000.0000.0002.00 |
| FABRIC | p3 | 49.0001.0000.0000.0003.00 |
| FABRIC | p4 | 49.0001.0000.0000.0004.00 |
| FABRIC | pe1 | 49.0001.0000.0001.0001.00 |
| FABRIC | pe2 | 49.0001.0000.0001.0002.00 |
| FABRIC | pe3 | 49.0001.0000.0001.0003.00 |
| FABRIC | rr1 | 49.0001.0000.0002.0001.00 |
| FABRIC | rr2 | 49.0001.0000.0002.0002.00 |
| FABRIC | p1 | 49.0001.0102.5500.0001.00 |
| FABRIC | p2 | 49.0001.0102.5500.0002.00 |
| FABRIC | p3 | 49.0001.0102.5500.0003.00 |
| FABRIC | p4 | 49.0001.0102.5500.0004.00 |
| FABRIC | pe1 | 49.0001.0102.5500.1001.00 |
| FABRIC | pe2 | 49.0001.0102.5500.1002.00 |
| FABRIC | pe3 | 49.0001.0102.5500.1003.00 |
| FABRIC | rr1 | 49.0001.0102.5500.2001.00 |
| FABRIC | rr2 | 49.0001.0102.5500.2002.00 |

### VTEP Loopback VXLAN Tunnel Source Interfaces (VTEPs Only)

Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/configs/p1.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ no ip routing vrf MGMT
ip route vrf MGMT 0.0.0.0/0 172.16.1.1
!
router isis CORE
net 49.0001.0000.0000.0001.00
net 49.0001.0102.5500.0001.00
is-type level-2
router-id ipv4 10.255.0.1
log-adjacency-changes
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/configs/p2.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ no ip routing vrf MGMT
ip route vrf MGMT 0.0.0.0/0 172.16.1.1
!
router isis CORE
net 49.0001.0000.0000.0002.00
net 49.0001.0102.5500.0002.00
is-type level-2
router-id ipv4 10.255.0.2
log-adjacency-changes
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/configs/p3.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ no ip routing vrf MGMT
ip route vrf MGMT 0.0.0.0/0 172.16.1.1
!
router isis CORE
net 49.0001.0000.0000.0003.00
net 49.0001.0102.5500.0003.00
is-type level-2
router-id ipv4 10.255.0.3
log-adjacency-changes
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/configs/p4.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ no ip routing vrf MGMT
ip route vrf MGMT 0.0.0.0/0 172.16.1.1
!
router isis CORE
net 49.0001.0000.0000.0004.00
net 49.0001.0102.5500.0004.00
is-type level-2
router-id ipv4 10.255.0.4
log-adjacency-changes
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/configs/pe1.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ router ospf 10 vrf C1_VRF1
redistribute bgp
!
router isis CORE
net 49.0001.0000.0001.0001.00
net 49.0001.0102.5500.1001.00
is-type level-2
router-id ipv4 10.255.1.1
log-adjacency-changes
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/configs/pe2.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ router ospf 10 vrf C1_VRF1
redistribute bgp
!
router isis CORE
net 49.0001.0000.0001.0002.00
net 49.0001.0102.5500.1002.00
is-type level-2
router-id ipv4 10.255.1.2
log-adjacency-changes
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/configs/pe3.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ router ospf 10 vrf C1_VRF1
redistribute bgp
!
router isis CORE
net 49.0001.0000.0001.0003.00
net 49.0001.0102.5500.1003.00
is-type level-2
router-id ipv4 10.255.1.3
log-adjacency-changes
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/configs/rr1.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ router bgp 65001
neighbor RR-OVERLAY-PEERS activate
!
router isis CORE
net 49.0001.0000.0002.0001.00
net 49.0001.0102.5500.2001.00
is-type level-2
router-id ipv4 10.255.2.1
log-adjacency-changes
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/configs/rr2.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ router bgp 65001
neighbor RR-OVERLAY-PEERS activate
!
router isis CORE
net 49.0001.0000.0002.0002.00
net 49.0001.0102.5500.2002.00
is-type level-2
router-id ipv4 10.255.2.2
log-adjacency-changes
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/structured_configs/p1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ loopback_interfaces:
router_isis:
instance: CORE
log_adjacency_changes: true
net: 49.0001.0000.0000.0001.00
net: 49.0001.0102.5500.0001.00
router_id: 10.255.0.1
is_type: level-2
address_family_ipv4:
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/structured_configs/p2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ loopback_interfaces:
router_isis:
instance: CORE
log_adjacency_changes: true
net: 49.0001.0000.0000.0002.00
net: 49.0001.0102.5500.0002.00
router_id: 10.255.0.2
is_type: level-2
address_family_ipv4:
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/structured_configs/p3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ loopback_interfaces:
router_isis:
instance: CORE
log_adjacency_changes: true
net: 49.0001.0000.0000.0003.00
net: 49.0001.0102.5500.0003.00
router_id: 10.255.0.3
is_type: level-2
address_family_ipv4:
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/structured_configs/p4.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ loopback_interfaces:
router_isis:
instance: CORE
log_adjacency_changes: true
net: 49.0001.0000.0000.0004.00
net: 49.0001.0102.5500.0004.00
router_id: 10.255.0.4
is_type: level-2
address_family_ipv4:
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/structured_configs/pe1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ loopback_interfaces:
router_isis:
instance: CORE
log_adjacency_changes: true
net: 49.0001.0000.0001.0001.00
net: 49.0001.0102.5500.1001.00
router_id: 10.255.1.1
is_type: level-2
address_family_ipv4:
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/structured_configs/pe2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ loopback_interfaces:
router_isis:
instance: CORE
log_adjacency_changes: true
net: 49.0001.0000.0001.0002.00
net: 49.0001.0102.5500.1002.00
router_id: 10.255.1.2
is_type: level-2
address_family_ipv4:
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/structured_configs/pe3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ loopback_interfaces:
router_isis:
instance: CORE
log_adjacency_changes: true
net: 49.0001.0000.0001.0003.00
net: 49.0001.0102.5500.1003.00
router_id: 10.255.1.3
is_type: level-2
address_family_ipv4:
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/structured_configs/rr1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ loopback_interfaces:
router_isis:
instance: CORE
log_adjacency_changes: true
net: 49.0001.0000.0002.0001.00
net: 49.0001.0102.5500.2001.00
router_id: 10.255.2.1
is_type: level-2
address_family_ipv4:
Expand Down
2 changes: 1 addition & 1 deletion ansible_collections/arista/avd/examples/isis-ldp-ipvpn/intended/structured_configs/rr2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ loopback_interfaces:
router_isis:
instance: CORE
log_adjacency_changes: true
net: 49.0001.0000.0002.0002.00
net: 49.0001.0102.5500.2002.00
router_id: 10.255.2.2
is_type: level-2
address_family_ipv4:
Expand Down
4 changes: 2 additions & 2 deletions ...tions/arista/avd/molecule/eos_designs-l2ls/documentation/devices/ISIS-SPINE1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ ip route 10.1.0.0/16 10.1.100.100
| Settings | Value |
| -------- | ----- |
| Instance | EVPN_UNDERLAY |
| Net-ID | 49.0001.0001.0000.0001.00 |
| Net-ID | 49.0001.1921.6825.5001.00 |
| Type | level-2 |
| Router-ID | 192.168.255.1 |
| Log Adjacency Changes | True |
Expand Down Expand Up @@ -353,7 +353,7 @@ ip route 10.1.0.0/16 10.1.100.100
```eos
!
router isis EVPN_UNDERLAY
net 49.0001.0001.0000.0001.00
net 49.0001.1921.6825.5001.00
is-type level-2
redistribute connected
redistribute static
Expand Down
2 changes: 1 addition & 1 deletion ...arista/avd/molecule/eos_designs-l2ls/documentation/fabric/L2LS-documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@

| POD | Node | CLNS Address |
| --- | ---- | ------------ |
| L2LS_ISIS | ISIS-SPINE1 | 49.0001.0001.0000.0001.00 |
| L2LS_ISIS | ISIS-SPINE1 | 49.0001.1921.6825.5001.00 |

### VTEP Loopback VXLAN Tunnel Source Interfaces (VTEPs Only)

Expand Down
Loading
Loading