Feat(eos_designs)!: Improve logic for BGP configuration of network services VRFs

[ClausHolbechArista]

Change Summary

Feat(eos_designs)!: Improve logic for BGP configuration of network services VRFs

Related issue(s)

Fixes #3052

Component(s) name

arista.avd.eos_designs

Proposed changes

New improve logic for BGP configuration of network services VRFs

AVD versions below 5.0.0 did not generate BGP configuration for VRFs unless the node type included evpn or mpls under default_address_families and the
VRF had the same evpn or mpls defined under address_families (default is ['evpn']).

AVD version 4.6.0 introduced the toggle new_network_services_bgp_vrf_config: <bool; default=false> to change this behavior by no longer requiring evpn
in the address-families, but instead it always configured BGP for all VRFs. This toggle has been removed in AVD 5.0.0 since this is now part of the default
behavior.

With AVD version 5.0.0, the logic of whether to configure BGP for a network services VRF has been improved with the following rules:

• New: Honor the new optional bgp.enabled setting, to either always or never configure BGP for the VRF.
• Existing: If the VRF is part of an overlay (evpn or mpls), BGP will be configured for the VRF.
• New: If any BGP peers are configured under the VRF, BGP will be configured for the VRF. This is useful for L2LS designs with VRFs.
• Improved: If uplink type is p2p-vrfs and the VRF is included in the uplink VRFs, BGP will be configured for the VRF.

It is possible to forcefully add or remove BGP configuration per VRF by setting:

<network_services_key e.g. tenants>:
  - name: mytenant
    vrfs:
      - name: myvrf
        bgp:
          enabled: <bool>  # <-- New optional setting to either always or never configure BGP for the VRF

How to test

Adjusted the exisisting tests to produce same outputs by exercising the new bgp.enabled knob

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4358
# Activate the virtual environment
source test-avd-pr-4358/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/flip-default-of-new_network_services_bgp_vrf_config#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/flip-default-of-new_network_services_bgp_vrf_config --force
# Optional: Install AVD examples
cd test-avd-pr-4358
ansible-playbook arista.avd.install_examples

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[laxmikantchintakindi]

LGTM. Tested by setting 'bgp:false' on vrf NOT_WAN_VRF in ansible_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/CV_PATHFINDER_TESTS.yml.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[ClausHolbechArista]

Moving to draft while fixing mlag

things have changed

[ClausHolbechArista]

does this fix #3052 completely?

It was confirmed by the submitter who tested this PR :)

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud