-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(cv_deploy): Ensure 'AVD Configurations' container is inserted first #4356
Fix(cv_deploy): Ensure 'AVD Configurations' container is inserted first #4356
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4356
# Activate the virtual environment
source test-avd-pr-4356/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/cv_deploy/insert-avd-config-container-at-the-top#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/cv_deploy/insert-avd-config-container-at-the-top --force
# Optional: Install AVD examples
cd test-avd-pr-4356
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Ensure 'AVD Configurations' container is inserted first so configs can be overridden by other static configlets or reconciled configs.
Related Issue(s)
BUG990962
Component(s) name
arista.avd.cv_deploy
Proposed changes
How to test
Tested manually with
cv_deploy
molecule scenario. Added a reconcile container and deleted the AVD config container. The container was recreated and inserted first.Checklist
User Checklist
Repository Checklist