-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut(eos_cli_config_gen): Removing 'null' as valid value of esp integrity and encryption from ip-security module #4336
Cut(eos_cli_config_gen): Removing 'null' as valid value of esp integrity and encryption from ip-security module #4336
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4336
# Activate the virtual environment
source test-avd-pr-4336/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@ip-security#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,ip-security --force
# Optional: Install AVD examples
cd test-avd-pr-4336
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can add test for the changes
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ip_security.schema.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update title to say what you are actually removing.
Also update release notes and porting guide. The old "null"
option has been replaced with "disabled"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
4463790
to
e7bd282
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
…ity and encryption from ip-security module (aristanetworks#4336)
Change Summary
Removing 'null' as valid values of esp integrity and encryption from ip-security module.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Removed the null as valid values of both esp integrity and encryption and added more valid values.
How to test
NA
Checklist
User Checklist
Repository Checklist