Refactor(eos_designs,eos_cli_config_gen): Default validation_mode to error and remove conversion_mode #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4327
# Activate the virtual environment
source test-avd-pr-4327/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/plugins/default-validation-mode-error#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/plugins/default-validation-mode-error --force
# Optional: Install AVD examples
cd test-avd-pr-4327
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
type: documentation
13 tasks
Vibhu-gslab
force-pushed
the
refactor/plugins/default-validation-mode-error
branch
from
394725b to
a193ac8
Compare
ansible_collections/arista/avd/plugins/plugin_utils/schema/avdschematools.py
Outdated
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Aug 9, 2024
ansible_collections/arista/avd/docs/contribution/eos_designs_internal_notes.md
Outdated
Show resolved
Hide resolved
…nternal_notes.md Co-authored-by: Mahesh Kumar <[email protected]>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
MaheshGSLAB
approved these changes
Aug 12, 2024
carlbuchmann
approved these changes
Aug 12, 2024
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
…error and remove conversion_mode (aristanetworks#4327) Co-authored-by: Mahesh Kumar <[email protected]>
ClausHolbechArista
deleted the
refactor/plugins/default-validation-mode-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Default validation_mode to error and remove conversion_mode
Related Issue(s)
Fixes #
Component(s) name
arista.avd.<role-name>Proposed changes
How to test
Checklist
User Checklist
Repository Checklist