Cut(eos_designs): Remove the deprecated ipv6_address_virtual key from SVI settings #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4314
# Activate the virtual environment
source test-avd-pr-4314/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@svi-settings#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,svi-settings --force
# Optional: Install AVD examples
cd test-avd-pr-4314
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
ClausHolbechArista
approved these changes
Aug 5, 2024
Vibhu-gslab
force-pushed
the
svi-settings
branch
from
7ed6cfd to
2b4565f
Compare
for more information, see https://pre-commit.ci
Shivani-gslab
requested changes
Aug 5, 2024
python-avd/pyavd/_eos_designs/structured_config/network_services/vlan_interfaces.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Claus Holbech <[email protected]> Co-authored-by: laxmikantchintakindi <[email protected]>
Co-authored-by: laxmikantchintakindi <[email protected]>
ClausHolbechArista
approved these changes
Aug 6, 2024
laxmikantchintakindi
approved these changes
Aug 6, 2024
ClausHolbechArista
approved these changes
Aug 6, 2024
|
ClausHolbechArista
changed the title
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove deprecated key(ipv6_address_virtual) for svi-settings schema.
Related Issue(s)
Fixes #
Component(s) name
`arista.avd.eos_designs
Proposed changes
Remove deprecated key(ipv6_address_virtual) for svi-settings schema.
Removed tests from deprecated vars
How to test
Run deprecated vars molecule
Checklist
User Checklist
Repository Checklist