Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(eos_designs): Remove deprecated keys from bgp_peer_groups #4307

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Remove deprecated keys IPv4_UNDERLAY_PEERS, MLAG_IPv4_UNDERLAY_PEER and EVPN_OVERLAY_PEERS from bgp_peer_groups schema

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Checklist

User Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4307
# Activate the virtual environment
source test-avd-pr-4307/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@dep_bgp_peer#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,dep_bgp_peer --force
# Optional: Install AVD examples
cd test-avd-pr-4307
ansible-playbook arista.avd.install_examples

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review August 2, 2024 11:10
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners August 2, 2024 11:10
Copy link

sonarqubecloud bot commented Aug 2, 2024

@MaheshGSLAB MaheshGSLAB requested a review from a team August 2, 2024 11:33
@ClausHolbechArista ClausHolbechArista merged commit fb2b27f into aristanetworks:devel Aug 2, 2024
40 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants