Feat(plugins): Add strict mode and ignore_case flags to natural_sort filter #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4298
# Activate the virtual environment
source test-avd-pr-4298/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@natural-sort-upgrade#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,natural-sort-upgrade --force
# Optional: Install AVD examples
cd test-avd-pr-4298
ansible-playbook arista.avd.install_examples |
ClausHolbechArista
approved these changes
Jul 31, 2024
ClausHolbechArista
requested changes
Jul 31, 2024
github-actions
bot
added
type: documentation
|
The special catch in the template of |
github-actions
bot
added
the
state: CI Updated
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
removed
the
state: CI Updated
ClausHolbechArista
approved these changes
Aug 2, 2024
ClausHolbechArista
added
the
one approval
|
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
…filter (aristanetworks#4298) Co-authored-by: Claus Holbech <[email protected]> Co-authored-by: Carl Buchmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This PR adds two new flags to the
natural_sortfilterstrictflag to be able to raise when thesort_keyis missing in one item in the iterable dict or Namespace (default isFalsefor backward compatibility).ignore_caseflag to be able to not ignore the case. Today natural_sort callslowerby default on some strings and this leads to AVD generating config not in the same order as EOS which does not uselower.Related Issue(s)
Fixes #4242
Component(s) name
pluginsProposed changes
Adding two flags to the function, with backward compatible default values to avoid impacting the rest of AVD
The goal is then to review the config ordering we have today against EOS and to use the flags where appropriate.
How to test
pytests have been added
Checklist
Note to reviewers
sortfrom Jinja -> is it worth it?Repository Checklist