Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(eos_cli_config_gen): Remove deprecated key entropy_source from management_security data model #4277

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Jul 29, 2024

Change Summary

Remove deprecated var for management_security.entropy_source from templates.

Related Issue(s)

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Remove deprecated var for management_security.entropy_source from templates.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Jul 29, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4277
# Activate the virtual environment
source test-avd-pr-4277/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@management_security_deprecated#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,management_security_deprecated --force
# Optional: Install AVD examples
cd test-avd-pr-4277
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jul 29, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Feat(eos_cli_config_gen): Remove key management_security.entropy_source from templates Feat(eos_cli_config_gen): Marked key entropy_source as removed from management_security data model Jul 29, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Feat(eos_cli_config_gen): Marked key entropy_source as removed from management_security data model Refactor(eos_cli_config_gen): Marked key entropy_source as removed from management_security data model Jul 29, 2024
@laxmikantchintakindi laxmikantchintakindi force-pushed the management_security_deprecated branch from 7b82a02 to 2744a00 Compare July 30, 2024 08:25
@laxmikantchintakindi laxmikantchintakindi force-pushed the management_security_deprecated branch from 2744a00 to e4fd7eb Compare July 30, 2024 09:48
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jul 30, 2024
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_cli_config_gen): Marked key entropy_source as removed from management_security data model Cut(eos_cli_config_gen): Remove deprecated key entropy_source from management_security data model Jul 30, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the management_security_deprecated branch from e4fd7eb to bdd1a53 Compare July 30, 2024 11:10
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review July 30, 2024 11:10
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners July 30, 2024 11:10
Copy link

@ClausHolbechArista ClausHolbechArista merged commit 86c4d5b into aristanetworks:devel Jul 30, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Cut(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants