Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump: Minimum Python version 3.10 #4276

Merged

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jul 29, 2024

Bump: Minimum Python version 3.10 incl update of docs and removal of special 3.9 workarounds.

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4276
# Activate the virtual environment
source test-avd-pr-4276/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@bump/drop-python3.9#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,bump/drop-python3.9 --force
# Optional: Install AVD examples
cd test-avd-pr-4276
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation type: code quality CI and development toolset labels Jul 29, 2024
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review July 29, 2024 13:19
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners July 29, 2024 13:19
Copy link

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested with Python 3.9 and correct errors are raised

@gmuloc gmuloc requested a review from carlbuchmann July 29, 2024 14:46
@ClausHolbechArista ClausHolbechArista merged commit 38050a2 into aristanetworks:devel Jul 29, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Bump type: code quality CI and development toolset type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants