Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(eos_cli_config_gen): Remove the deprecated key local_interface from stun server data model #4274

Merged
merged 8 commits into from
Jul 30, 2024
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,6 @@ The following data model keys have been removed from `eos_cli_config_gen` in v5.
| old key 10.1(router_isis) | new key(TODO) |
| old key 10.2(router_isis) | new key(TODO) |
| old key 11(snmp_server) | new key(TODO) |
| old key 12(stun) | new key(TODO) |
| stun.server.local_interface | stun.server.local_interfaces |
| old key 13.1(vlan_interfaces) | new key(TODO) |
| old key 13.2(vlan_interfaces) | new key(TODO) |
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@
- [QOS Class Maps](#qos-class-maps)
- [QOS Policy Maps](#qos-policy-maps)
- [QOS Profiles](#qos-profiles)
- [STUN](#stun)
- [STUN Server](#stun-server)
- [STUN Device Configuration](#stun-device-configuration)
- [Maintenance Mode](#maintenance-mode)
- [BGP Groups](#bgp-groups)
- [Interface Groups](#interface-groups)
Expand Down Expand Up @@ -1817,23 +1814,6 @@ qos profile test
no priority
```

## STUN

### STUN Server

| Server Local Interfaces | Bindings Timeout (s) | SSL Profile | SSL Connection Lifetime | Port |
| ----------------------- | -------------------- | ----------- | ----------------------- | ---- |
| Ethernet1 | - | - | - | 3478 |

### STUN Device Configuration

```eos
!
stun
server
local-interface Ethernet1
```

## Maintenance Mode

### BGP Groups
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -615,10 +615,6 @@ management api gnmi
vrf MONITORING
provider eos-native
!
stun
server
local-interface Ethernet1
!
management ssh
!
vrf mgt
Expand Down

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@
{% set lifetime = "-" %}
{% endif %}
{% set interface_list = stun.server.local_interfaces | arista.avd.natural_sort %}
{# Next is deprecated remove in v5.0.0 #}
{% if stun.server.local_interface is arista.avd.defined %}
{% do interface_list.append(stun.server.local_interface) %}
{% endif %}
| {{ interface_list | join("<br>") }} | {{ bindings_timeout }} | {{ ssl_profile }} | {{ lifetime }} | {{ stun_port }} |
{% endif %}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,6 @@ stun
{% for local_interface in stun.server.local_interfaces | arista.avd.natural_sort %}
local-interface {{ local_interface }}
{% endfor %}
{# Next is deprecated remove in v5.0.0 #}
{% if stun.server.local_interface is arista.avd.defined %}
local-interface {{ stun.server.local_interface }}
{% endif %}
{% if stun.server.port is arista.avd.defined %}
port {{ stun.server.port }}
{% endif %}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@ keys:
type: dict
description: STUN server settings.
keys:
local_interface:
type: str
deprecation:
warning: true
new_key: local_interfaces
remove_in_version: v5.0.0
local_interfaces:
type: list
min_length: 1
Expand Down Expand Up @@ -87,3 +81,10 @@ keys:
max: 65535
convert_types:
- str
local_interface:
type: str
deprecation:
removed: true
warning: true
new_key: local_interfaces
remove_in_version: v5.0.0

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading